Skip to content

Diagnostics Signs Not Working #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
valyntyler opened this issue Apr 28, 2025 · 3 comments
Open
1 task done

Diagnostics Signs Not Working #863

valyntyler opened this issue Apr 28, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@valyntyler
Copy link
Contributor

⚠️ Please verify that this bug has NOT been reported before.

  • I checked all existing issues and didn't find a similar issue

Description

It seems that at the time of writing the vim.diagnostics.config.signs option is broken. Giving it a boolean value seems to work fine but following the example in the docs, I was unable to customize the diagnostics sign characters.

👟 Reproduction steps

set vim.diagnostics.config.signs to docs example:
{ signs = { text = { "vim.diagnostic.severity.ERROR" = "󰅚 "; "vim.diagnostic.severity.WARN" = "󰀪 "; }; }; }

👀 Expected behavior

signcol contains (󰅚/󰀪)

😓 Actual Behavior

signcol contains (E/W)

💻 Metadata

  • system: "x86_64-linux" - host os: Linux 6.12.24, NixOS, 25.05 (Warbler), 25.05.20250424.f771eb4 - multi-user?: yes - sandbox: yes - version: nix-env (Nix) 2.28.2 - nixpkgs: /nix/store/707m8gfbdyxhg1sgkiw5x9zh84ya012r-source

📝 Relevant log output

n/a
@valyntyler valyntyler added the bug Something isn't working label Apr 28, 2025
@NotAShelf
Copy link
Owner

This has been brought to my attention recently. Looks like we cannot actually set this inside the diagnostics submodule as a limitation of toLuaObject that we use internally.

You can, for now, use lua inside luaConfigRC to set diagnostic signs. I will also add. top-level module to allow setting those in Nix from a different API.

@valyntyler
Copy link
Contributor Author

This has been brought to my attention recently. Looks like we cannot actually set this inside the diagnostics submodule as a limitation of toLuaObject that we use internally.

You can, for now, use lua inside luaConfigRC to set diagnostic signs. I will also add. top-level module to allow setting those in Nix from a different API.

Alright, thanks for the reply! I am (very) new to nfv and I'm loving it so far. I thought I was going a bit mad when I took the example from the docs and it didn't end up working since everything else so far has been seamless. I'd (humbly) suggest removing the broken example temporarily since it could be seen as confusing. In any case, I love what you're doing and thankd for taking the time to reply

@NotAShelf
Copy link
Owner

I'll certainly remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants