Skip to content

Commit 255a3be

Browse files
committed
Remove ipv6 test leftovers
Signed-off-by: Daniel Fetti <[email protected]>
1 parent a7075cb commit 255a3be

File tree

6 files changed

+0
-36
lines changed

6 files changed

+0
-36
lines changed

config/manager_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ func TestConfigDefaultValues(t *testing.T) {
159159
assert.False(t, cfg.Mesh)
160160
assert.False(t, cfg.KillSwitch)
161161
assert.Equal(t, test.autoconnect, cfg.AutoConnect)
162-
assert.False(t, cfg.IPv6)
163162
assert.True(t, cfg.VirtualLocation.Get())
164163
})
165164
}

test/qa/lib/__init__.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,6 @@
7272
"off",
7373
]
7474

75-
IPV6 = [
76-
"on",
77-
"off",
78-
]
79-
8075
# Used for test parametrization, when the same test has to be run for obfuscated technologies.
8176
STANDARD_GROUPS = [
8277
"Africa_The_Middle_East_And_India",
@@ -136,14 +131,6 @@
136131
"Paris",
137132
]
138133

139-
# Used for testing, when specific server is offine.
140-
#
141-
# curl api.nordvpn.com/v1/servers\?limit=6000 -L | jq '[.[] | select((.ips | length) > 1)] | map(.hostname |= rtrimstr(".nordvpn.com")) | map(.hostname)'
142-
IPV6_SERVERS = [
143-
"us9591", "us9592"
144-
]
145-
146-
147134
class Protocol(Enum):
148135
UDP = "UDP"
149136
TCP = "TCP"
@@ -254,13 +241,6 @@ def set_dns(dns):
254241
print("WARNING:", ex)
255242

256243

257-
def set_ipv6(ipv6):
258-
try:
259-
print(sh.nordvpn.set.ipv6(ipv6))
260-
except sh.ErrorReturnCode_1 as ex:
261-
print("WARNING:", ex)
262-
263-
264244
def set_firewall(firewall):
265245
try:
266246
print(sh.nordvpn.set.firewall(firewall))

test/qa/lib/firewall.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,6 @@ def _get_rules_allowlist_subnet_and_port_on(interface: str, subnets: list[str],
289289
return result
290290

291291

292-
# TODO: Add missing IPv6 rules (icmp6 & dhcp6)
293292
def _get_firewall_rules(ports: list[Port] | None = None, subnets: list[str] | None = None) -> list[str]:
294293
# Default route interface
295294
interface = sh.ip.route.show("default").split(None)[4]

test/qa/test_connect6.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,12 @@ def setup_function(function): # noqa: ARG001
1818
daemon.start()
1919
login.login_as("default")
2020
logging.log()
21-
print(sh.nordvpn.set.ipv6.on())
2221

2322

2423
def teardown_function(function): # noqa: ARG001
2524
logging.log(data=info.collect())
2625
logging.log()
2726

28-
print(sh.nordvpn.set.ipv6.off())
2927
sh.nordvpn.logout("--persist-token")
3028
sh.nordvpn.set.defaults("--logout")
3129
daemon.stop()

test/qa/test_firewall6.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ def test_connected_firewall_disable(tech, proto, obfuscated):
3939
with lib.Defer(sh.nordvpn.disconnect):
4040
lib.set_technology_and_protocol(tech, proto, obfuscated)
4141

42-
lib.set_ipv6("on")
4342
lib.set_firewall("on")
4443
assert not firewall.is_active()
4544

@@ -58,7 +57,6 @@ def test_connected_firewall_enable(tech, proto, obfuscated):
5857
with lib.Defer(sh.nordvpn.disconnect):
5958
lib.set_technology_and_protocol(tech, proto, obfuscated)
6059

61-
lib.set_ipv6("on")
6260
lib.set_firewall("off")
6361
assert not firewall.is_active()
6462

@@ -77,7 +75,6 @@ def test_firewall_disable_connect(tech, proto, obfuscated):
7775
with lib.Defer(sh.nordvpn.disconnect):
7876
lib.set_technology_and_protocol(tech, proto, obfuscated)
7977

80-
lib.set_ipv6("on")
8178
lib.set_firewall("off")
8279
assert not firewall.is_active()
8380

@@ -93,7 +90,6 @@ def test_firewall_enable_connect(tech, proto, obfuscated):
9390
with lib.Defer(sh.nordvpn.disconnect):
9491
lib.set_technology_and_protocol(tech, proto, obfuscated)
9592

96-
lib.set_ipv6("on")
9793
lib.set_firewall("on")
9894
assert not firewall.is_active()
9995

@@ -112,7 +108,6 @@ def test_firewall_ipv6_02_allowlist_port(tech, proto, obfuscated, port):
112108
lib.set_technology_and_protocol(tech, proto, obfuscated)
113109

114110
lib.set_firewall("on")
115-
lib.set_ipv6("on")
116111
allowlist.add_ports_to_allowlist([port])
117112
assert not firewall.is_active([port])
118113

@@ -135,7 +130,6 @@ def test_firewall_ipv6_03_allowlist_ports_range(tech, proto, obfuscated, ports):
135130
lib.set_technology_and_protocol(tech, proto, obfuscated)
136131

137132
lib.set_firewall("on")
138-
lib.set_ipv6("on")
139133
allowlist.add_ports_to_allowlist([ports])
140134
assert not firewall.is_active([ports])
141135

@@ -158,7 +152,6 @@ def test_firewall_ipv6_04_allowlist_port_and_protocol(tech, proto, obfuscated, p
158152
lib.set_technology_and_protocol(tech, proto, obfuscated)
159153

160154
lib.set_firewall("on")
161-
lib.set_ipv6("on")
162155
allowlist.add_ports_to_allowlist([port])
163156
assert not firewall.is_active([port])
164157

@@ -181,7 +174,6 @@ def test_firewall_ipv6_05_allowlist_subnet(tech, proto, obfuscated, subnet):
181174
lib.set_technology_and_protocol(tech, proto, obfuscated)
182175

183176
lib.set_firewall("on")
184-
lib.set_ipv6("on")
185177
allowlist.add_subnet_to_allowlist([subnet])
186178
assert not firewall.is_active(None, [subnet])
187179

@@ -202,7 +194,6 @@ def test_firewall_ipv6_06_with_killswitch(tech, proto, obfuscated):
202194
lib.set_technology_and_protocol(tech, proto, obfuscated)
203195

204196
lib.set_firewall("on")
205-
lib.set_ipv6("on")
206197
assert not firewall.is_active()
207198

208199
lib.set_killswitch("on")
@@ -217,7 +208,6 @@ def test_firewall_ipv6_07_with_killswitch_while_connected(tech, proto, obfuscate
217208
lib.set_technology_and_protocol(tech, proto, obfuscated)
218209

219210
lib.set_firewall("on")
220-
lib.set_ipv6("on")
221211
assert not firewall.is_active()
222212

223213
lib.set_killswitch("on")

test/qa/test_meshnet_vpn.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,15 +162,13 @@ def test_set_defaults_when_connected_2nd_set(tech, proto, obfuscated):
162162

163163
sh_no_tty.nordvpn.set.firewall("off")
164164
sh_no_tty.nordvpn.set.tpl("on")
165-
sh_no_tty.nordvpn.set.ipv6("on")
166165

167166
sh_no_tty.nordvpn.connect()
168167
assert "Status: Connected" in sh_no_tty.nordvpn.status()
169168

170169
assert not settings.is_firewall_enabled()
171170
assert settings.is_meshnet_enabled()
172171
assert settings.is_tpl_enabled()
173-
assert settings.is_ipv6_enabled()
174172

175173
if obfuscated == "on":
176174
assert settings.is_obfuscated_enabled()

0 commit comments

Comments
 (0)