Skip to content

Commit 4273739

Browse files
mihaitodorrelistan
authored andcommitted
Fix Envoy gRPC API listener names
The listener names need to be unique for each service port and the virtual host names need to be set to the service name, just like in the legacy JSON REST API implementation.
1 parent 61ad9e7 commit 4273739

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

envoy/adapter/adapter.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ func envoyListenerFromService(svc *service.Service, envoyServiceName string,
172172
RouteConfig: &api.RouteConfiguration{
173173
ValidateClusters: &wrappers.BoolValue{Value: false},
174174
VirtualHosts: []*route.VirtualHost{{
175-
Name: envoyServiceName,
175+
Name: svc.Name,
176176
Domains: []string{"*"},
177177
Routes: []*route.Route{{
178178
Match: &route.RouteMatch{
@@ -214,7 +214,7 @@ func envoyListenerFromService(svc *service.Service, envoyServiceName string,
214214
}
215215

216216
return &api.Listener{
217-
Name: svc.Name,
217+
Name: envoyServiceName,
218218
Address: &core.Address{
219219
Address: &core.Address_SocketAddress{
220220
SocketAddress: &core.SocketAddress{

envoy/server_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func validateListener(serialisedListener *any.Any, svc service.Service) {
4343
listener := &api.Listener{}
4444
err := ptypes.UnmarshalAny(serialisedListener, listener)
4545
So(err, ShouldBeNil)
46-
So(listener.Name, ShouldEqual, svc.Name)
46+
So(listener.Name, ShouldEqual, adapter.SvcName(svc.Name, svc.Ports[0].ServicePort))
4747
So(listener.GetAddress().GetSocketAddress().GetAddress(), ShouldEqual, bindIP)
4848
So(listener.GetAddress().GetSocketAddress().GetPortValue(), ShouldEqual, svc.Ports[0].ServicePort)
4949
filterChains := listener.GetFilterChains()

0 commit comments

Comments
 (0)