Skip to content

Better support for HEIC files #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PoeHaH opened this issue Nov 24, 2024 · 3 comments
Open

Better support for HEIC files #26

PoeHaH opened this issue Nov 24, 2024 · 3 comments

Comments

@PoeHaH
Copy link

PoeHaH commented Nov 24, 2024

First of all: thank you for maintaining this! Not sure what happened to the original Dropzone but it's widely used so I'm happy to see interest in further keeping this alive :-).

Images taken with iPhone cameras are often stored in a raw format with ".heic" extension. Their mime type is "image/heic" so Dropzone tries to render a thumbnail preview, but it doesn't work:
image

In the source code, we can see why the thumbnail can't be displayed:
image

In short, the dataUrl is not a string, but an object.

I propose to fix this by making a simple change to the thumbnail() function to check if the dataUrl is a string.
image

Would you be open to add this into the next release?

@NicolasCARPi
Copy link
Owner

NicolasCARPi commented Nov 25, 2024

Hello,

Would you be open to add this into the next release?

Yes, please open a PR and I'll look into it. Please add an example HEIC file in there too!

Not sure what happened to the original Dropzone

Something I see a lot in the open source world: project maintainer simply lost interest in the project and let it die the worst ay: not answering nor providing access to a new maintainer. C'est la vie !

@PoeHaH
Copy link
Author

PoeHaH commented Nov 25, 2024

This makes me sound stupid but do you have a doc on how to open a PR? 😊

Yeah, that's part of open source!

@NicolasCARPi
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants