Skip to content

Commit aa9ba18

Browse files
committed
Include characters that need to be url encoded in test suite
1 parent 147d50f commit aa9ba18

File tree

1 file changed

+17
-11
lines changed

1 file changed

+17
-11
lines changed

spring-cloud-netflix-eureka-client/src/test/java/org/springframework/cloud/netflix/eureka/http/AbstractEurekaHttpClientTest.java

+17-11
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
import com.netflix.discovery.shared.Applications;
2121
import com.netflix.discovery.shared.transport.EurekaHttpClient;
2222
import org.junit.jupiter.api.Test;
23+
import org.junit.jupiter.params.ParameterizedTest;
24+
import org.junit.jupiter.params.provider.ValueSource;
2325

2426
import org.springframework.http.HttpStatus;
2527

@@ -46,9 +48,10 @@ void testCancel() {
4648
assertThat(eurekaHttpClient.cancel("test", "test").getStatusCode()).isEqualTo(HttpStatus.OK.value());
4749
}
4850

49-
@Test
50-
void testSendHeartBeat() {
51-
assertThat(eurekaHttpClient.sendHeartBeat("test", "test", info, null).getStatusCode())
51+
@ParameterizedTest
52+
@ValueSource(strings = { "test", "test#1.[3.?]!" })
53+
void testSendHeartBeat(String instanceId) {
54+
assertThat(eurekaHttpClient.sendHeartBeat("test", instanceId, info, null).getStatusCode())
5255
.isEqualTo(HttpStatus.OK.value());
5356
}
5457

@@ -58,10 +61,12 @@ void testSendHeartBeatFourOFour() {
5861
.isEqualTo(HttpStatus.NOT_FOUND.value());
5962
}
6063

61-
@Test
62-
void testStatusUpdate() {
63-
assertThat(eurekaHttpClient.statusUpdate("test", "test", InstanceInfo.InstanceStatus.UP, info).getStatusCode())
64-
.isEqualTo(HttpStatus.OK.value());
64+
@ParameterizedTest
65+
@ValueSource(strings = { "test", "test#1.[3.?]!" })
66+
void testStatusUpdate(String instanceId) {
67+
assertThat(
68+
eurekaHttpClient.statusUpdate("test", instanceId, InstanceInfo.InstanceStatus.UP, info).getStatusCode())
69+
.isEqualTo(HttpStatus.OK.value());
6570
}
6671

6772
@Test
@@ -100,10 +105,11 @@ void testGetApplication() {
100105
eurekaHttpClient.getApplication("test");
101106
}
102107

103-
@Test
104-
void testGetInstance() {
105-
eurekaHttpClient.getInstance("test");
106-
eurekaHttpClient.getInstance("test", "test");
108+
@ParameterizedTest
109+
@ValueSource(strings = { "test", "test#1.[3.?]!" })
110+
void testGetInstance(String instanceId) {
111+
eurekaHttpClient.getInstance(instanceId);
112+
eurekaHttpClient.getInstance("test", instanceId);
107113
}
108114

109115
}

0 commit comments

Comments
 (0)