Skip to content

Commit 9ca8b2f

Browse files
Merge pull request #742 from tulikabhatt/fix_boolean_decoder
Remove trailing/leading whitespace in boolean decoder
2 parents 56adbe4 + 6c71747 commit 9ca8b2f

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

archaius2-core/src/main/java/com/netflix/archaius/converters/DefaultTypeConverterFactory.java

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ public final class DefaultTypeConverterFactory implements TypeConverter.Factory
3535
public static final DefaultTypeConverterFactory INSTANCE = new DefaultTypeConverterFactory();
3636

3737
private static Boolean convertBoolean(String value) {
38+
value = value.trim();
3839
if (value.equalsIgnoreCase("true") || value.equalsIgnoreCase("yes") || value.equalsIgnoreCase("on")) {
3940
return Boolean.TRUE;
4041
}

archaius2-core/src/test/java/com/netflix/archaius/DefaultDecoderTest.java

+7
Original file line numberDiff line numberDiff line change
@@ -176,4 +176,11 @@ public void testTypeConverterRegistry() {
176176
class Foo {}
177177
assertFalse(DefaultDecoder.INSTANCE.get(Foo.class).isPresent());
178178
}
179+
180+
@Test
181+
public void testConvertBoolean() {
182+
DefaultDecoder decoder = DefaultDecoder.INSTANCE;
183+
boolean flag = decoder.decode(boolean.class, " true ");
184+
assertTrue(flag);
185+
}
179186
}

0 commit comments

Comments
 (0)