Fixes #167 (Unsafe concurrent access to unknown lease collection in AssignableVMs class) (#168)

Fixes #167 (Unsafe concurrent access to unknown lease collection in AssignableVMs class)

Author: tbak

fenzo-core/src/main/java/com/netflix/fenzo/AssignableVMs.java

@@ -85,7 +85,7 @@ void assignResult(TaskAssignmentResult result) {
     };
     private final ActiveVmGroups activeVmGroups;
     private String activeVmGroupAttributeName=null;
-    private final List<String> unknownLeaseIdsToExpire = new ArrayList<>();
+    private final BlockingQueue<String> unknownLeaseIdsToExpire = new LinkedBlockingQueue<>();
 
     AssignableVMs(TaskTracker taskTracker, Action1<VirtualMachineLease> leaseRejectAction,
                   long leaseOfferExpirySecs, int maxOffersToReject,
@@ -181,7 +181,8 @@ private int addLeases(List<VirtualMachineLease> leases) {
     void expireLease(String leaseId) {
         final String hostname = leaseIdToHostnameMap.get(leaseId);
         if(hostname==null) {
-            unknownLeaseIdsToExpire.add(leaseId);
+            logger.debug("Received expiry request for an unknown lease: {}", leaseId);
+            unknownLeaseIdsToExpire.offer(leaseId);
             return;
         }
         internalExpireLease(leaseId, hostname);
@@ -253,13 +254,12 @@ private boolean isInActiveVmGroup(String attrValue) {
     }
 
     private void expireAnyUnknownLeaseIds() {
-        if(!unknownLeaseIdsToExpire.isEmpty()) {
-            for(String leaseId: unknownLeaseIdsToExpire) {
-                final String hostname = leaseIdToHostnameMap.get(leaseId);
-                if(hostname!=null)
-                    internalExpireLease(leaseId, hostname);
-            }
-            unknownLeaseIdsToExpire.clear();
+        List<String> unknownExpiredLeases = new ArrayList<>();
+        unknownLeaseIdsToExpire.drainTo(unknownExpiredLeases);
+        for(String leaseId: unknownExpiredLeases) {
+            final String hostname = leaseIdToHostnameMap.get(leaseId);
+            if(hostname!=null)
+                internalExpireLease(leaseId, hostname);
         }
     }