Remove port serdes object before removing port (sonic-net#2152)

kcudnik · web-flow · commit 7d2942f7ef4a · 2022-02-21T11:43:21.000-08:00
* Remove port serdes object before removing port
diff --git a/orchagent/portsorch.cpp b/orchagent/portsorch.cpp
@@ -2289,6 +2289,13 @@ sai_status_t PortsOrch::removePort(sai_object_id_t port_id)
     }
     /* else : port is in default state or not yet created */
 
+    /*
+     * Remove port serdes (if exists) before removing port since this
+     * reference is dependency.
+     */
+
+    removePortSerdesAttribute(port_id);
+
     sai_status_t status = sai_port_api->remove_port(port_id);
     if (status != SAI_STATUS_SUCCESS)
     {

Original file line number	Diff line number	Diff line change
`@@ -2289,6 +2289,13 @@ sai_status_t PortsOrch::removePort(sai_object_id_t port_id)`
`2289`	`2289`	`}`
`2290`	`2290`	`/* else : port is in default state or not yet created */`
`2291`	`2291`
	`2292`	`+ /*`
	`2293`	`+ * Remove port serdes (if exists) before removing port since this`
	`2294`	`+ * reference is dependency.`
	`2295`	`+ */`
	`2296`	`+`
	`2297`	`+ removePortSerdesAttribute(port_id);`
	`2298`	`+`
`2292`	`2299`	`sai_status_t status = sai_port_api->remove_port(port_id);`
`2293`	`2300`	`if (status != SAI_STATUS_SUCCESS)`
`2294`	`2301`	`{`