Skip to content

Replace shell commands with subprocess.run #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

balvisio
Copy link
Collaborator

Description

Instead of using shell commands in Jupyter Notebooks we replace them with calls to subprocess.run so that in case of failure we have better logging of the error.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor
  • Documentation update
  • Other (please describe): Improvement to logging

CI Pipeline Configuration

Configure CI behavior by applying the relevant labels:

Note

By default, the notebooks validation tests are skipped unless explicitly enabled.

Authorizing CI Runs

We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.

  • If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will
    automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
  • If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an
    /ok to test comment on the pull request to trigger CI. This will need to be done for each new commit.

Usage

TODO: Add code snippet

Pre-submit Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly
  • I have added/updated tests as needed
  • All existing tests pass successfully

Copy link

copy-pr-bot bot commented Jun 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@balvisio balvisio force-pushed the ba/BIONEMO-2086-replace-shell-commands-in-jupyter-nbs branch from 2b90947 to 5622869 Compare June 13, 2025 23:18
@balvisio
Copy link
Collaborator Author

/ok to test 5622869

@balvisio balvisio force-pushed the ba/BIONEMO-2086-replace-shell-commands-in-jupyter-nbs branch 10 times, most recently from 5919932 to d106dca Compare June 20, 2025 05:16
@balvisio balvisio force-pushed the ba/BIONEMO-2086-replace-shell-commands-in-jupyter-nbs branch from d106dca to f099aec Compare June 23, 2025 15:29
@balvisio
Copy link
Collaborator Author

/ok to test f099aec

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.19%. Comparing base (a6f5a7f) to head (f099aec).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
- Coverage   84.20%   84.19%   -0.02%     
==========================================
  Files         144      144              
  Lines        9224     9224              
==========================================
- Hits         7767     7766       -1     
- Misses       1457     1458       +1     

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants