Skip to content

Colspan breaks the sorting in the latest version #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jvetyska opened this issue May 23, 2012 · 6 comments
Closed

Colspan breaks the sorting in the latest version #78

jvetyska opened this issue May 23, 2012 · 6 comments
Labels

Comments

@jvetyska
Copy link

If a table has a colspan in the header, trying to sort on that column will cause js error.

@Mottie
Copy link
Owner

Mottie commented May 23, 2012

I have this demo with multiple colspans and I'm not seeing an error... is it a particular browser?

@jvetyska
Copy link
Author

The demo you mention here is a little bit something new.
I am talking about normal header colspan, without any other header rows.
Such as:

<thead>
<tr><th colspan="2">Name</th><th>number</th></tr>
</thead>
<tbody>
<tr><td>Some person 1</td>
      <td><a href=action1>delete</a></td>
      <td>555-777-9999</td>
</tr>

This type of table is not functional with the latest version. It worked the whole time beautifully until now.
It has something to do with the css for the sub-headers (that are not there, of course).

@Mottie
Copy link
Owner

Mottie commented May 23, 2012

Ok, thanks for clarifying that. I'll have the problem fixed in the next update.

@jvetyska
Copy link
Author

Hi Mottie,

This may be related to this same issue, but I found another problem related to using the normal colspan.

It was really hard to narrow it down, because it only occurs with the compiled code and only when jquery.metadata is also included. It throws a javascript exception, that isn't very helpful.
I tried to reproduce it with your examples, using the same compiled code, no problem. The moment I added a colspan, I got the same error.

So apparently metadata, just like the css is causing issues with colspan.

@Mottie
Copy link
Owner

Mottie commented May 28, 2012

Ok, hopefully these colspan issues have been fixed in v2.3.5.

@Mottie Mottie closed this as completed Jun 10, 2012
@jvetyska
Copy link
Author

Thanks for fixing, works great now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants