Interaction component fixes + improvements (#6030)

## About The Pull Request

Fixes #4569

I refactored and improved interaction component code quite a bit, with
the goal of preventing further bugs/exploits, and making them more
reliable overall.

I've added config options in case further exploits pop up, to help
prevent the exploit without code-side disabling, until its properly
fixed:
```
## Uncomment to prevent mechcomp interaction components from holding items.
#DISABLE_MECHCOMP_INTERACTION_ITEMS

## Uncomment to prevent mechcomp interaction components from using storage.
#DISABLE_MECHCOMP_INTERACTION_STORAGE

## Additional typepaths to prevent mechcomp interaction components from interacting with.
#BLACKLIST_MECHCOMP_INTERACTION /obj/item/doohickey
#BLACKLIST_MECHCOMP_INTERACTION /obj/item/thingymajig
```

also added some (currently unused) precursor code for a future refactor
of regex find/replace components

<details>
<summary><h3>Proof of Testing</h3></summary>

![2025-03-24 (1742841779) ~
dreamseeker](https://github.com/user-attachments/assets/9a3c9940-0f29-4535-8cb1-f571f918c360)
![2025-03-24 (1742841790) ~
dreamseeker](https://github.com/user-attachments/assets/5fbe2704-5846-4cfe-8db9-678f9fa6ed83)

</details>

## Why It's Good For The Game

i want my funny interaction components back

## Changelog
:cl:
add: Re-added interaction components to the mechcomp vendor.
fix: Fixed some further potential exploits with interaction components.
code: Cleaned up a lot of interaction component code.
map: Added a mechcomp vendor to runtimestation.
config: Added config options to disable interaction components holding
items or interacting with storage components.
config: Added a config option to add more item types to the interaction
component blacklist.
/:cl:

Author: Absolucy

_maps/map_files/debug/runtimestation.dmm

@@ -959,6 +959,11 @@
 "dV" = (
 /turf/open/floor/plating,
 /area/station/hallway/secondary/entry)
+"dW" = (
+/obj/effect/turf_decal/stripes/line,
+/obj/machinery/vending/mechcomp,
+/turf/open/floor/iron,
+/area/station/commons/storage/primary)
 "dY" = (
 /turf/closed/wall/r_wall,
 /area/station/hallway/secondary/entry)
@@ -8318,7 +8323,7 @@ Ut
 cm
 cK
 by
-dB
+dW
 dx
 dl
 dl

code/__DEFINES/traits/monkestation/declarations.dm

@@ -127,8 +127,11 @@
 #define TRAIT_GIFT_ITEM				"gift_item"
 /// The mob can see pathogen clouds and such.
 #define TRAIT_VIRUS_SCANNER "virus_scanner"
-///This item always renders. (only used for stupid magboots rn)
+/// This item always renders. (only used for stupid magboots rn)
 #define TRAIT_ALWAYS_RENDER			"always_render"
+/// Prevents mechcomp interaction components from interacting with this object.
+#define TRAIT_MECHCOMP_INTERACTION_BANNED "mechcomp_interaction_banned"
+
 // /atom/movable
 /// Things with this trait can pass through wooden barricades.
 #define TRAIT_GOES_THROUGH_WOODEN_BARRICADES	"goes_through_wooden_barricades"

code/_globalvars/traits/_traits.dm

@@ -642,6 +642,7 @@ GLOBAL_LIST_INIT(traits_by_type, list(
 		"TRAIT_LABOURED_BREATHING" = TRAIT_LABOURED_BREATHING,
 		"TRAIT_MAT_TRANSMUTED" = TRAIT_MAT_TRANSMUTED,
 		"TRAIT_MAY_CONTAIN_BLENDED_DUST" = TRAIT_MAY_CONTAIN_BLENDED_DUST,
+		"TRAIT_MECHCOMP_INTERACTION_BANNED" = TRAIT_MECHCOMP_INTERACTION_BANNED,
 		"TRAIT_NEEDS_TWO_HANDS" = TRAIT_NEEDS_TWO_HANDS,
 		"TRAIT_NODROP" = TRAIT_NODROP,
 		"TRAIT_NO_WORN_ICON" = TRAIT_NO_WORN_ICON,
@@ -658,6 +659,7 @@ GLOBAL_LIST_INIT(traits_by_type, list(
 		"TRAIT_T_RAY_VISIBLE" = TRAIT_T_RAY_VISIBLE,
 		"TRAIT_UNCATCHABLE" = TRAIT_UNCATCHABLE,
 		"TRAIT_WIELDED" = TRAIT_WIELDED,
+		"TRAIT_MECHCOMP_INTERACTION_BANNED" = TRAIT_MECHCOMP_INTERACTION_BANNED,
 		/* "TRAIT_BAIT_UNCONSUMABLE" = TRAIT_BAIT_UNCONSUMABLE, */
 		/* "TRAIT_BAKEABLE" = TRAIT_BAKEABLE, */
 		/* "TRAIT_BYPASS_RANGED_ARMOR" = TRAIT_BYPASS_RANGED_ARMOR, */

code/controllers/configuration/entries/monkestation.dm

@@ -45,6 +45,27 @@
 
 /datum/config_entry/flag/disable_storyteller
 
+/datum/config_entry/flag/disable_mechcomp_interaction_items
+
+/datum/config_entry/flag/disable_mechcomp_interaction_storage
+
+/datum/config_entry/str_list/blacklist_mechcomp_interaction
+
+/datum/config_entry/str_list/blacklist_mechcomp_interaction/ValidateAndSet(str_val)
+	. = ..()
+	if(!.)
+		return
+	var/list/config_entry_value = src.config_entry_value
+	var/list/list_values = config_entry_value.Copy()
+	config_entry_value.Cut()
+	for(var/path_to_blacklist in list_values)
+		var/path = text2path(trimtext(path_to_blacklist))
+		if(isnull(path))
+			log_config("Warning: invalid typepath [path_to_blacklist] in BLACKLIST_MECHCOMP_INTERACTION")
+			continue
+		for(var/current_path in typesof(path))
+			config_entry_value[current_path] = TRUE
+
 /datum/config_entry/number/transfer_vote_time
 	default = 90 MINUTES
 	min_val = 0

code/datums/elements/food/fried_item.dm

@@ -37,7 +37,7 @@
 			this_food.name = "\proper the physical manifestation of the very concept of fried foods"
 			this_food.desc = "A heavily-fried... something. Who can tell anymore?"
 
-	ADD_TRAIT(this_food, TRAIT_FOOD_FRIED, ELEMENT_TRAIT(type))
+	this_food.add_traits(list(TRAIT_FOOD_FRIED, TRAIT_MECHCOMP_INTERACTION_BANNED), ELEMENT_TRAIT(type)) // monkestation edit: also add TRAIT_MECHCOMP_INTERACTION_BANNED
 	SEND_SIGNAL(this_food, COMSIG_ITEM_FRIED, fry_time)
 	// Already edible items will inherent these parameters
 	// Otherwise, we will become edible.
@@ -55,6 +55,6 @@
 		source.remove_atom_colour(FIXED_COLOUR_PRIORITY, color)
 	source.name = initial(source.name)
 	source.desc = initial(source.desc)
-	REMOVE_TRAIT(source, TRAIT_FOOD_FRIED, ELEMENT_TRAIT(type))
+	source.remove_traits(list(TRAIT_FOOD_FRIED, TRAIT_MECHCOMP_INTERACTION_BANNED), ELEMENT_TRAIT(type)) // monkestation edit: also add TRAIT_MECHCOMP_INTERACTION_BANNED
 	qdel(source.GetComponent(/datum/component/edible)) // Don't care if it was initially edible
 	return ..()

code/modules/unit_tests/mob_faction.dm

@@ -6,7 +6,8 @@
 	var/list/ignored = list(
 		/mob/living/carbon,
 		/mob/dview,
-		/mob/oranges_ear
+		/mob/oranges_ear,
+		/mob/living/carbon/human/dummy/mechcomp, // monkestation addition: should not exist outside of interaction components
 	)
 	ignored += typesof(/mob/camera/imaginary_friend)
 	ignored += typesof(/mob/living/simple_animal/pet/gondola/gondolapod)

code/modules/unit_tests/unit_test.dm

@@ -247,17 +247,18 @@ GLOBAL_VAR_INIT(focused_tests, focused_tests())
 		//Both are abstract types meant to scream bloody murder if spawned in raw
 		/obj/item/organ/external,
 		/obj/item/organ/external/wings,
+		// monkestation start
 		/obj/effect/spawner/random_engines,
 		/obj/effect/spawner/random_bar,
-		///this instant starts a timer, and if its being instantly deleted it can cause issues
-		/obj/machinery/atm,
-		/datum/hotspot,
+		/obj/machinery/atm, // starts a timer, and if its being instantly deleted it can cause issues
 		/obj/machinery/ocean_elevator,
 		/atom/movable/outdoor_effect,
 		/turf/closed/mineral/random/regrowth,
-		/obj/effect/abstract/signboard_holder, // monkestation addition: shouldn't exist outside of signboards
-		/obj/effect/transmission_beam, // monkestation addition: relies on the existence of a PTL
-		/obj/item/radio/entertainment/speakers/pda, // monkestation addition: should never exist outside of a modular computer
+		/obj/effect/abstract/signboard_holder, // shouldn't exist outside of signboards
+		/obj/effect/transmission_beam, // relies on the existence of a PTL
+		/obj/item/radio/entertainment/speakers/pda, // shouldn't outside of a modular computer
+		/mob/living/carbon/human/dummy/mechcomp, // shouldn't outside of an interaction component
+		// monkestation end
 	)
 	//Say it with me now, type template
 	ignore += typesof(/obj/effect/mapping_helpers)
@@ -328,14 +329,14 @@ GLOBAL_VAR_INIT(focused_tests, focused_tests())
 	ignore += subtypesof(/atom/movable/screen/escape_menu)
 	///we generate mobs in these and create destroy does this in null space
 	ignore += typesof(/obj/item/loot_table_maker)
+
+	// monkestation start
 	///we need to use json_decode to run randoms properly
 	ignore += typesof(/obj/item/device/cassette_tape)
-	ignore += typesof(/datum/cassette/cassette_tape)
 	///we also dont want weathers or weather events as they will hold refs to alot of stuff as they shouldn't be deleted
-	ignore += typesof(/datum/weather_event)
-	ignore += typesof(/datum/particle_weather)
 	ignore += typesof(/mob/living/basic/aquatic)
 	ignore += typesof(/obj/machinery/station_map)
+	// monkestation end
 
 	return ignore
 

config/game_options.txt

@@ -604,3 +604,13 @@ MODERATE_POP_SCALE_PENALTY 30
 MAJOR_POP_SCALE_PENALTY 30
 ROLESET_POP_SCALE_PENALTY 30
 OBJECTIVES_POP_SCALE_PENALTY 30
+
+## Uncomment to prevent mechcomp interaction components from holding items.
+#DISABLE_MECHCOMP_INTERACTION_ITEMS
+
+## Uncomment to prevent mechcomp interaction components from using storage.
+#DISABLE_MECHCOMP_INTERACTION_STORAGE
+
+## Additional typepaths to prevent mechcomp interaction components from interacting with.
+#BLACKLIST_MECHCOMP_INTERACTION /obj/item/doohickey
+#BLACKLIST_MECHCOMP_INTERACTION /obj/item/thingymajig