Tgui Player & Options panel - Please Review Me (#4846)

* wasawasa

* wasa

* 1

* updatus

* bowwwwwwwwwwww

* i fink its done chief

* oop

* final final final v45?

* oop

* Updates post prelim review

* Update to fix some things

Update to fix some things:
Updated F6 keybind to use new pp
updated the pp to be on /datum/admins/ not a client proc (safety ig)
fixed centcom galactic db
fixed account age/first seen

* Fix Soulless Corpses not being PPable

Fixed soulless corpses not being PPable. as far as I can tell this works

* Update VethPlayerPanel.tsx

* Adds Admin AI Interact button to PP

* Adds "Also Known as"

Also known as is a searchable target for the frontend, and backend displays all previous character names that the person has used.

* Removes sinful one letter variables

* Replaces pretty much all of the old player panel cases apart from the verb itself

it's still accessable, just a lil bit hidden u know...

* Consistency update to make sure it always grabs the correct mob

* Updated with requested changes

* Commenting update. Send it poobs.

Author: Veth-s

code/datums/keybinding/admin.dm

@@ -30,14 +30,14 @@
 	hotkey_keys = list("F6")
 	name = "player_panel_new"
 	full_name = "Player Panel New"
-	description = "Opens up the new player panel"
+	description = "Opens up the new TGUI player panel"
 	keybind_signal = COMSIG_KB_ADMIN_PLAYERPANELNEW_DOWN
 
 /datum/keybinding/admin/player_panel_new/down(client/user)
 	. = ..()
 	if(.)
 		return
-	user.holder.player_panel_new()
+	user.holder.player_panel_veth()
 	return TRUE
 
 /datum/keybinding/admin/toggle_buildmode_self

code/modules/admin/admin_verbs.dm

@@ -51,6 +51,9 @@ GLOBAL_PROTECT(admin_verbs_admin)
 	/datum/verbs/menu/Admin/verb/playerpanel, /* It isn't /datum/admin but it fits no less */
 	/datum/admins/proc/kick_player_by_ckey, //MONKESTATION ADDITION - kick a player by their ckey
 	/datum/admins/proc/change_shuttle_events, //allows us to change the shuttle events
+	/datum/admins/proc/player_panel_veth,
+	/datum/admins/proc/vuap_open_context,
+	/datum/admins/proc/vuap_open,
 // Client procs
 	/client/proc/admin_call_shuttle, /*allows us to call the emergency shuttle*/
 	/client/proc/admin_cancel_shuttle, /*allows us to cancel the emergency shuttle, sending it back to centcom*/

code/modules/admin/topic.dm

@@ -725,7 +725,9 @@
 
 	else if(href_list["adminplayeropts"])
 		var/mob/M = locate(href_list["adminplayeropts"])
-		show_player_panel(M)
+		usr.client.VUAP_selected_mob = M
+		usr.client.selectedPlayerCkey = M.ckey
+		usr.client.holder.vuap_open()
 
 	else if(href_list["ppbyckey"])
 		var/target_ckey = href_list["ppbyckey"]
@@ -740,7 +742,9 @@
 			return
 
 		to_chat(usr, span_notice("Jumping to [target_ckey]'s new mob: [target_mob]!"))
-		show_player_panel(target_mob)
+		usr.client.VUAP_selected_mob = target_mob
+		usr.client.selectedPlayerCkey = target_mob.ckey
+		usr.client.holder.vuap_open()
 
 	else if(href_list["adminopendemo"])
 		usr.client << link("http://viewer.monkestation.com/?roundid=[GLOB.round_id]&password=[CONFIG_GET(string/replay_password)]#[world.time]") //opens current round at current time

code/modules/mob/mob.dm

@@ -1337,7 +1337,9 @@
 	if(href_list[VV_HK_PLAYER_PANEL])
 		if(!check_rights(NONE))
 			return
-		usr.client.holder.show_player_panel(src)
+		usr.client.VUAP_selected_mob = src
+		usr.client.selectedPlayerCkey = src.ckey
+		usr.client.holder.vuap_open()
 	if(href_list[VV_HK_GODMODE])
 		if(!check_rights(R_ADMIN))
 			return

code/modules/requests/request_manager.dm

@@ -170,8 +170,9 @@ GLOBAL_DATUM_INIT(requests, /datum/request_manager, new)
 
 	switch(action)
 		if ("pp")
-			var/mob/M = request.owner?.mob
-			usr.client.holder.show_player_panel(M)
+			usr.client.VUAP_selected_mob = request.owner?.mob
+			usr.client.selectedPlayerCkey = request.owner?.mob.ckey
+			usr.client.holder.vuap_open()
 			return TRUE
 		if ("vv")
 			var/mob/M = request.owner?.mob

code/modules/wiremod/core/admin_panel.dm

@@ -68,7 +68,9 @@
 			circuit.ui_interact(usr)
 		if ("open_player_panel")
 			var/datum/mind/inserter = circuit.inserter_mind?.resolve()
-			usr.client?.holder?.show_player_panel(inserter?.current)
+			usr.client.VUAP_selected_mob = inserter?.current
+			usr.client.selectedPlayerCkey = inserter?.current?.ckey
+			usr.client?.holder?.vuap_open()
 
 	return TRUE
 

monkestation/code/modules/veth_misc_items/veth_player_panel/readme.md

@@ -0,0 +1,29 @@
+## Title: <!--Title of your addition-->
+
+<!-- uppercase, underscore_connected name of your module, that you use to mark files-->
+MODULE ID: TGUIPLAYERPANEL 
+
+### Description:
+This PR adds a TGUI version of player panel. It should have all of the features of the current player panel, with some additional "most used" buttons on the main player panel. Ideally, if all goes well, I'd like to phase out the older player panel, but this will need extensive testing.
+
+### Master file additions
+
+- N/A
+<!-- Any master file changes you've made to existing master files or if you've added a new master file. Please mark either as #NEW or #CHANGE -->
+
+### Included files that are not contained in this module:
+
+#NEW tgui/packages/tgui/interfaces/VUAP_personal.tsx
+#NEW tgui/packages/tgui/interfaces/veth_player_panel.tsx
+#CHANGE code/modules/admin/admin_verbs.dm
+
+
+<!-- Likewise, be it a non-modular file or a modular one that's not contained within the folder belonging to this specific module, it should be mentioned here -->
+
+### Credits:
+
+<!-- Here go the credits to you, dear coder, and in case of collaborative work or ports, credits to the original source of the code -->
+<!-- Original Coders -->
+Made by Veth
+Special thanks to Fleepy, Pooba & Absolucy for their help. 
+