Skip to content

feat: Adds Minecraft Run Command and Reload World on Restart Option #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

DauntlessStudio
Copy link
Contributor

@DauntlessStudio DauntlessStudio commented Apr 9, 2025

Minecraft Run Command

Adds the existing but unreferenced minecraft-debugger.runMinecraftCommand to the command palette when in debug mode as "Minecraft Run Command". Running the command will open an input box to send a command to Minecraft. This can be a simple way of executing one-off commands in addition to the Minecraft Command Shortcuts.

@JakeShirley JakeShirley requested a review from chmeyer-ms April 11, 2025 16:30
@JakeShirley
Copy link
Collaborator

Thanks for submitting this! We may take a few weeks to review it, sorry about that.

Copy link
Contributor

@chmeyer-ms chmeyer-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where you're going with this. The changes to runMinecraftCommand look good, would you mind isolating that in a separate PR?

The reloadall feature may need some additional client/minecraft coordinated work. It needs to work for both listen and connect scenarios and ideally would not require attach debugger on load. I'll set aside some time for this. Thanks for the PR.

@DauntlessStudio
Copy link
Contributor Author

@chmeyer-ms Sorry for the delay, I have isolated the runMinecraftCommand feature to this PR.

As for the reload all, I could make it work with both listen and connect with attach debugger on load. But making it work without that feature, I don't think I could do just on the extension side. Minecraft preparing to attach to the debugger when the world re-opens is pivotal to re-connecting so there would need to be some alternate way to tell Minecraft to do that without enabling the setting. Is that something I should leave with you, or should I make a separate PR for that feature with the limitation of requiring attach debugger on load?

Copy link
Contributor

@chmeyer-ms chmeyer-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature, thanks for doing this.

@chmeyer-ms chmeyer-ms merged commit faaa2f5 into Mojang:main May 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants