fix(source-maps): Use alternate source map bias only if the default returns null and the alternate does not. Remove as user option to reduce config confusion. #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frgarc
approved these changes
Feb 18, 2025
frgarc
approved these changes
Feb 18, 2025
…eturns null and the alternate does not. Remove as user option to reduce config confusion.
chmeyer-ms
force-pushed
the
chmeyer/bias
branch
from
63719e4 to
2802bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to reduce config options (and confusion), this removes the sourceMapBias param from the launch config. The default source map bias is 'leastUpperBound', which works with our published ts config in TS Starter. This config is also used in the source-map unit tests. If leastUpperBound fails, it will try greatestLowerBound but will not switch to that as the preferred bias unless it succeeds.