Skip to content

fix(source-maps): Improve error messages and logs when working with source maps. #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

chmeyer-ms
Copy link
Contributor

@chmeyer-ms chmeyer-ms commented Feb 14, 2025

Improve user messaging, including logs and notifications, when working with source maps.
Output resolved sourceMapRoot, localRoot, and generatedSourceRoot to the debug console on connect.
Show warning notifications when expected files are not found, like if sourceMapRoot is set but it can't find .map files or .js files, or if sourceMapRoot is not defined but .ts files are found in local root etc.

Remove inlineSourceMaps from package.json, infer inline or external from files found at sourceMapRoot. One less thing for the user to configure.

Remove special case for inline source maps when encountering /scripts/ in source folder.

TS Starter pack now works with inline source maps with a one line change in just.config.ts:

const bundleTaskOptions: BundleTaskParameters = {
  ...
  sourcemap: "inline", // <--- from true to 'inline'
  ...
};

…ource maps. Remove special case for inline source maps when encountering /scripts/ in source folder.
@chmeyer-ms chmeyer-ms self-assigned this Feb 14, 2025
@chmeyer-ms chmeyer-ms merged commit 14f35cc into main Feb 14, 2025
5 checks passed
@chmeyer-ms chmeyer-ms deleted the chmeyer/fix_maps branch February 14, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants