feat(debugger): prompt user for target add-on id if not provided and multiple add-ons active in MC. #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeyer-ms
changed the title
chmeyer-ms
changed the title
chmeyer-ms
changed the title
JakeShirley
approved these changes
Sep 9, 2024
src/Session.ts
Outdated
| return; | ||
| } else { | ||
| this.showNotification( | ||
| `Minecraft Add-On not found with targetModuleUuid ${this._targetModuleUuid} specified in launch.json. Prompting for debug target.`, |
There was a problem hiding this comment.
Maybe this should reference the fact that this need to be the script module's UUID, not the add-on's/pack's UUID
| return; | ||
| } else { | ||
| this.showNotification( | ||
| 'The targetModuleUuid in launch.json is not set to a valid uuid. Set this to a script module uuid (manifest.json) to avoid the selection prompt.', |
There was a problem hiding this comment.
Does code blocks work in the notifications? If so, "The targetModuleUuid in launch.json..." might be better.
JakeShirley
reviewed
Sep 9, 2024
src/Session.ts
Outdated
| }; | ||
| window.showQuickPick(items, options).then(value => { | ||
| if (!value) { | ||
| this.terminateSession('could not determine target Minecraft Add-On.', LogLevel.Error); |
There was a problem hiding this comment.
Should this say something like "You must select a target module"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to improve the "it just works" scenarios, this PR presents a QuickPickMenu to the user if the targetModuleUUID is not set (or incorrect) and MC has multiple active add-ons.