Make namespace deserialization more resilient

Similar to #35

Author: stefcameron

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Management clusters are no longer selected by default after retrieving clusters from an MCC instance. They are typically of less interest. They can still be selected and added along with any other cluster, however.
 - Some notification messages have been shortened to make them quicker to read.
 - Made the cluster deserialization process more resilient (fixes #35).
+- Made the namespace deserialization process more resilient (similar to #35).
 
 ## 2.0.1
 

src/cc/store/ClustersProvider.js

@@ -56,16 +56,22 @@ const _deserializeNamespacesList = function (body) {
     return { error: strings.clustersProvider.errors.invalidNamespacePayload() };
   }
 
-  try {
-    return { data: body.items.map((item) => new Namespace(item)) };
-  } catch (err) {
-    // eslint-disable-next-line no-console -- OK to show errors
-    console.error(
-      `[${pkg.name}/ClustersProvider._deserializeNamespacesList()] ERROR: ${err.message}`,
-      err
-    );
-    return { error: strings.clustersProvider.errors.invalidNamespace() };
-  }
+  return {
+    data: body.items
+      .map((item, idx) => {
+        try {
+          return new Namespace(item);
+        } catch (err) {
+          // eslint-disable-next-line no-console -- OK to show errors
+          console.error(
+            `[${pkg.name}/ClustersProvider._deserializeNamespacesList()] ERROR with namespace ${idx}: ${err.message}`,
+            err
+          );
+          return undefined;
+        }
+      })
+      .filter((cl) => !!cl), // eliminate invalid namespaces (`undefined` items)
+  };
 };
 
 /**
@@ -134,7 +140,7 @@ const _deserializeClustersList = function (body) {
           return undefined;
         }
       })
-      .filter((cl) => !!cl), // eliminate failed clusters (`undefined` items)
+      .filter((cl) => !!cl), // eliminate invalid clusters (`undefined` items)
   };
 };
 

src/strings.ts

@@ -156,8 +156,6 @@ export const clustersProvider: Dict = {
   errors: {
     invalidNamespacePayload: () =>
       'Failed to parse namespace payload: Unexpected data format.',
-    invalidNamespace: () =>
-      'Encountered at least one namespace with unexpected or missing metadata.',
     invalidClusterPayload: () =>
       'Failed to parse cluster payload: Unexpected data format.',
   },