Merge pull request #69 from MineralsCloud:origin

Remove origins in `vertices` & `faces`

Author: singularitti

CrystallographyBase/src/lattice.jl

@@ -228,15 +228,15 @@ Get crystal periodicity in ``x``, ``y``, and ``z`` direction from the `Lattice`.
 """
 periodicity(lattice::Lattice) = Tuple(sum(abs, lattice.data; dims = 2))
 
-function vertices(lattice::Lattice, 𝐎 = fill(zero(first(lattice)), 3))
+function vertices(lattice::Lattice)
     𝐚, 𝐛, 𝐜 = latticevectors(lattice)
-    return map(𝐕 -> 𝐕 + 𝐎, (0 * 𝐚, 𝐚, 𝐛, 𝐜, 𝐚 + 𝐛, 𝐛 + 𝐜, 𝐚 + 𝐜, 𝐚 + 𝐛 + 𝐜))
+    return 0 * 𝐚, 𝐚, 𝐛, 𝐜, 𝐚 + 𝐛, 𝐛 + 𝐜, 𝐚 + 𝐜, 𝐚 + 𝐛 + 𝐜
 end
 
-function faces(lattice::Lattice, 𝐎 = zeros(eltype(lattice), 3))
+function faces(lattice::Lattice)
     faces =
         (1, 2, 3, 4), (5, 6, 7, 8), (1, 2, 6, 5), (3, 4, 8, 7), (2, 3, 7, 6), (5, 8, 4, 1)
-    verts = vertices(lattice, 𝐎)
+    verts = vertices(lattice)
     return map(face -> [verts[i] for i in face], faces)
 end