Skip to content

enableProposedApi not documented in package.json #33358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isidorn opened this issue Aug 29, 2017 · 10 comments
Closed

enableProposedApi not documented in package.json #33358

isidorn opened this issue Aug 29, 2017 · 10 comments
Assignees
Labels
api feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 29, 2017

Refs: #33248

enableProposedApi is not suggested in package.json inteli-sense
Due to that it is hard to discover this flag. Is this on purpose?

@jrieken
Copy link
Member

jrieken commented Aug 29, 2017

Yeah, that is actually on purpose because we don't want to over-promote this. Still, we should document somewhere how proposed API to be used

@jrieken jrieken added api feature-request Request for new features or functionality labels Oct 31, 2017
@aeschli
Copy link
Contributor

aeschli commented Feb 1, 2018

IMO we should add it. The description can explain the limitations you get when you use it. Given the limitations, there's IMO no danger that too many devs will use it.

@octref
Copy link
Contributor

octref commented Aug 2, 2018

@jrieken Can we include it in a section under Extensibility Reference in the website? I don't want to go into GitHub comments to find out the instruction for using proposed API each time. If that's fine, I can create a placeholder page in the website and you can fill in details.

Alternatively, as @rcjsuen suggested, put the instruction to the top of vscode.proposed.d.ts.

octref added a commit to microsoft/vscode-extension-samples that referenced this issue Oct 30, 2018
@octref octref closed this as completed Oct 30, 2018
@octref octref added the verification-needed Verification of issue is requested label Oct 30, 2018
@octref
Copy link
Contributor

octref commented Oct 30, 2018

@octref octref added this to the October 2018 milestone Oct 30, 2018
@jrieken
Copy link
Member

jrieken commented Oct 30, 2018

👍 for the documentation and 👎 for the sample. That will be out of date in no-time and I also don't think that it adds value

@octref
Copy link
Contributor

octref commented Oct 30, 2018

@jrieken However, currently it's awkward to update your code to use Proposed API. Each time I had to remember to do this:

  • Find latest vscode.d.ts
  • Change vscode.engines to *
  • Run postinstall scripts to download latest d.ts
  • Change vscode.engines back
  • Remember to add enabledProposedApi to package.json. I sometimes type it wrongly as API and nothing works.

If sample is not the right place, what do you think about adding another script to the vscode NPM module to automate this? So people can run node ./node_modules/vscode/use-proposed-api. We can print warnings and have confirmations here too.

@jrieken
Copy link
Member

jrieken commented Oct 31, 2018

@octref step 1 to 4 have nothing to do with proposed api. that's the procedure when coding against the latest, not yet published, version of vscode.d.ts and is only rarely needed.

for proposed API the three steps outline here are needed: https://code.visualstudio.com/updates/v1_28#_proposed-extension-apis

@octref
Copy link
Contributor

octref commented Oct 31, 2018

OK I'll drop the sample.

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 31, 2018

Should this issue be reopened or marked as wont-fix?

@octref
Copy link
Contributor

octref commented Oct 31, 2018

To verify:

@mjbvz mjbvz added the verified Verification succeeded label Oct 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants