Use template hgetall, because we will tune the return types of library functions (sonic-net#759)

qiluo-msft · web-flow · commit 6385d496997a · 2021-01-03T23:55:15.000-08:00
The template version of hgetall() could work with either map or unordered_map.
diff --git a/syncd/RedisClient.cpp b/syncd/RedisClient.cpp
@@ -672,7 +672,9 @@ std::unordered_map<std::string, std::string> RedisClient::getAttributesFromAsicK
 {
     SWSS_LOG_ENTER();
 
-    return m_dbAsic->hgetall(key);
+    std::unordered_map<std::string, std::string> map;
+    m_dbAsic->hgetall(key, std::inserter(map, map.end()));
+    return map;
 }
 
 bool RedisClient::hasNoHiddenKeysDefined() const

Original file line number	Diff line number	Diff line change
`@@ -672,7 +672,9 @@ std::unordered_map<std::string, std::string> RedisClient::getAttributesFromAsicK`
`672`	`672`	`{`
`673`	`673`	`SWSS_LOG_ENTER();`
`674`	`674`
`675`		`- return m_dbAsic->hgetall(key);`
	`675`	`+ std::unordered_map<std::string, std::string> map;`
	`676`	`+ m_dbAsic->hgetall(key, std::inserter(map, map.end()));`
	`677`	`+ return map;`
`676`	`678`	`}`
`677`	`679`
`678`	`680`	`bool RedisClient::hasNoHiddenKeysDefined() const`