Skip to content

[Bug]: Duplicate accounts in the vault break some user actions #15437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikesposito opened this issue May 19, 2025 · 0 comments · May be fixed by #15356
Open

[Bug]: Duplicate accounts in the vault break some user actions #15437

mikesposito opened this issue May 19, 2025 · 0 comments · May be fixed by #15356
Assignees
Labels
Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-wallet-framework type-bug Something isn't working

Comments

@mikesposito
Copy link
Member

Describe the bug

Duplicating accounts should now be impossible, though existing users with duplicates in the vault will be able to log in, but won't have a functioning wallet.

Expected behavior

Duplicates in the vault shouldn't break wallet functionality, and shouldn't be visible in the accounts menu

Screenshots/Recordings

No response

Steps to reproduce

  1. Switch to a release branch older than 7.41.0, build locally, and install the app on an emulator or phisical testing device.
  2. Onboard with an SRP of which we know the second account (child guilt hollow arrive average popular nasty soon summer like scheme diary pill country rapid)
  3. Import an account that is part of the mnemonic ( 0x80842b7e3cfb1118e86a427cdec418e3b4179ef5bbbfd71c02a76349831c8a8b which is the account at index 2 of the above SRP)
  4. Add a new account on the main HD
  5. Switch to the 7.46.0 branch, and refresh the app on the device
  6. Unlock the wallet, you should see duplicates in your accounts list and you won't be able to add new accounts

Error messages or log output

May be visible in the logs:

KeyringController - The account you are trying to import is a duplicate

Detection stage

In production (default)

Version

<7.47.0

Build type

None

Device

All

Operating system

iOS, Android

Additional context

No response

Severity

No response

@mikesposito mikesposito self-assigned this May 19, 2025
@mikesposito mikesposito added type-bug Something isn't working Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing labels May 19, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity May 19, 2025
@github-project-automation github-project-automation bot moved this to To be triaged in Bugs by team May 19, 2025
@mikesposito mikesposito linked a pull request May 19, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-wallet-framework type-bug Something isn't working
Projects
Status: To be fixed
Status: To be triaged
Development

Successfully merging a pull request may close this issue.

1 participant