Skip to content

[Bug]: Smart Transactions enabled - send+swap transaction marked in a different way within the Activity tab #25357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sleepytanya opened this issue Jun 15, 2024 · 1 comment · Fixed by #25510
Closed

[Bug]: Smart Transactions enabled - send+swap transaction marked in a different way within the Activity tab #25357

sleepytanya opened this issue Jun 15, 2024 · 1 comment · Fixed by #25510
Labels
regression-RC-12.0.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-transactions Transactions team type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Jun 15, 2024 •
edited
Loading

Describe the bug

Smart Transactions enabled - send+swap transaction marked in a different way within the Activity tab.

Probably related (?): #24929

Expected behavior

Screenshots/Recordings

pepeMetis.mov
Screenshot 2024-06-15 at 17 17 16 Screenshot 2024-06-15 at 17 19 27
dawnPepeOneLine.mov
Screenshot 2024-06-15 at 17 24 56

Steps to reproduce

  1. Start send+swap transaction

Error messages or log output

No response

Version

12.0.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@sleepytanya sleepytanya added type-bug Something isn't working regression-RC-12.0.0 labels Jun 15, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Jun 15, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jun 15, 2024
@sleepytanya sleepytanya added the team-transactions Transactions team label Jun 16, 2024
@dan437
Copy link
Contributor

dan437 commented Jun 20, 2024

I've removed the regression-RC-12.0.0 label, since we disabled smart transactions for this new Send&Swap feature here: #25422

We will make smart transactions work with Send&Swap in one of the future releases.

@gauthierpetetin gauthierpetetin added Sev2-normal Normal severity; minor loss of service or inconvenience. release-blocker This bug is blocking the next release labels Jun 20, 2024
@danjm danjm added regression-RC-12.0.0 and removed release-blocker This bug is blocking the next release labels Jun 25, 2024
@forest-diggs-consensys forest-diggs-consensys linked a pull request Jun 25, 2024 that will close this issue
fix: do not use STX for swap+send approval #25510
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Jun 25, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Jun 25, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-RC-12.0.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-transactions Transactions team type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not use STX for swap+send approval MetaMask/metamask-extension
5 participants
@gauthierpetetin @danjm @metamaskbot @dan437 @sleepytanya