Skip to content

Don't mutate user input in gas fields #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danfinlay opened this issue Mar 21, 2017 · 0 comments
Closed

Don't mutate user input in gas fields #1233

danfinlay opened this issue Mar 21, 2017 · 0 comments
Assignees
@danfinlay
Labels
type-bug Something isn't working

Comments

@danfinlay
Copy link
Contributor

Default gas is like 2000000. If you highlight that 2 and delete it, before you can type 3 or something, the input is mutated to be simply 0.

We shouldn't mutate user input. We should simply interpret it as best as we can, giving warnings & errors accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danfinlay danfinlay

Labels
type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danfinlay @2-am-zzz