Skip to content

Commit ed06176

Browse files
fix: display the correct symbol of a native currency (#25364)
## **Description** This PR fixes a small bug in the display of certain types of notifications. Specifically, in the case of receiving or sending notifications of native currencies, the symbol of the native currency is now correctly displayed. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25364?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="387" alt="Screenshot 2024-06-17 at 11 16 01" src="https://github.com/MetaMask/metamask-extension/assets/1284304/5f66746e-7b32-45a3-899a-672ef65db44e"> ### **After** <img width="443" alt="Screenshot 2024-06-17 at 11 43 31" src="https://github.com/MetaMask/metamask-extension/assets/1284304/686351cd-7940-499b-9e42-f626fe705677"> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 3820f01 commit ed06176

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ui/pages/notifications/notification-components/eth-sent-received/eth-sent-received.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ const getTitle = (n: ETHNotification) => {
6363
};
6464

6565
const getDescription = (n: ETHNotification) => {
66-
const { nativeCurrencyName } = getNativeCurrency(n);
67-
const items = createTextItems([nativeCurrencyName], TextVariant.bodyMd);
66+
const { nativeCurrencySymbol } = getNativeCurrency(n);
67+
const items = createTextItems([nativeCurrencySymbol], TextVariant.bodyMd);
6868
return items;
6969
};
7070

0 commit comments

Comments
 (0)