feat: support atomic batch transactions (#30271)

## **Description**

Support atomic batch transactions via EIP-5792 and EIP-7702.

Specifically:

- Upgrade `@metamask/transaction-controller` to support adding batch
transactions.
- Upgrade `@metamask/eth-json-rpc-middleware` to validate and process
EIP-5792 RPC requests.
- Patch `@etheremjs/tx` to fix nonce type in EIP-7702 authorizations.
- Add EIP-5792 utils to provide hooks for middleware.
- Add minimal support for `TransactionType.batch` in confirmations.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30271?quickstart=1)

## **Related issues**

Fixes [#4209](MetaMask/MetaMask-planning#4209)

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: matthewwalsh0

.yarn/patches/@ethereumjs-tx-npm-5.4.0-0c4a0f973e.patch

@@ -0,0 +1,130 @@
+diff --git a/dist/cjs/util.js b/dist/cjs/util.js
+index d60cf924ee8144ee49dd07e8e910d87a2c4bfb6a..ea5494530c05f4c831e301b88fef7855c89f2885 100644
+--- a/dist/cjs/util.js
++++ b/dist/cjs/util.js
+@@ -119,14 +119,11 @@ class AuthorizationLists {
+                 }
+                 const chainId = (0, util_1.hexToBytes)(item.chainId);
+                 const addressBytes = (0, util_1.hexToBytes)(item.address);
+-                const nonceList = [];
+-                for (let j = 0; j < item.nonce.length; j++) {
+-                    nonceList.push((0, util_1.hexToBytes)(item.nonce[j]));
+-                }
++                const nonce = (0, util_1.hexToBytes)(item.nonce);
+                 const yParity = (0, util_1.hexToBytes)(item.yParity);
+                 const r = (0, util_1.hexToBytes)(item.r);
+                 const s = (0, util_1.hexToBytes)(item.s);
+-                newAuthorizationList.push([chainId, addressBytes, nonceList, yParity, r, s]);
++                newAuthorizationList.push([chainId, addressBytes, nonce, yParity, r, s]);
+             }
+             bufferAuthorizationList = newAuthorizationList;
+         }
+@@ -138,18 +135,14 @@ class AuthorizationLists {
+                 const data = bufferAuthorizationList[i];
+                 const chainId = (0, util_1.bytesToHex)(data[0]);
+                 const address = (0, util_1.bytesToHex)(data[1]);
+-                const nonces = data[2];
+-                const nonceList = [];
+-                for (let j = 0; j < nonces.length; j++) {
+-                    nonceList.push((0, util_1.bytesToHex)(nonces[j]));
+-                }
++                const nonce = (0, util_1.bytesToHex)(data[2]);
+                 const yParity = (0, util_1.bytesToHex)(data[3]);
+                 const r = (0, util_1.bytesToHex)(data[4]);
+                 const s = (0, util_1.bytesToHex)(data[5]);
+                 const jsonItem = {
+                     chainId,
+                     address,
+-                    nonce: nonceList,
++                    nonce,
+                     yParity,
+                     r,
+                     s,
+@@ -167,20 +160,14 @@ class AuthorizationLists {
+         for (let key = 0; key < authorizationList.length; key++) {
+             const authorizationListItem = authorizationList[key];
+             const address = authorizationListItem[1];
+-            const nonceList = authorizationListItem[2];
++            const nonce = authorizationListItem[2];
+             const yParity = authorizationListItem[3];
+             const r = authorizationListItem[4];
+             const s = authorizationListItem[5];
+-            (0, util_1.validateNoLeadingZeroes)({ yParity, r, s });
++            (0, util_1.validateNoLeadingZeroes)({ yParity, r, s, nonce });
+             if (address.length !== 20) {
+                 throw new Error('Invalid EIP-7702 transaction: address length should be 20 bytes');
+             }
+-            if (nonceList.length > 1) {
+-                throw new Error('Invalid EIP-7702 transaction: nonce list should consist of at most 1 item');
+-            }
+-            else if (nonceList.length === 1) {
+-                (0, util_1.validateNoLeadingZeroes)({ nonce: nonceList[0] });
+-            }
+         }
+     }
+     static getDataFeeEIP7702(authorityList, common) {
+diff --git a/dist/esm/util.js b/dist/esm/util.js
+index 36fa7e9917f72b042efc753ba5d1c9cd0d5572db..de454fa2f09a98b2a8716e173d1cd1f87101a490 100644
+--- a/dist/esm/util.js
++++ b/dist/esm/util.js
+@@ -114,14 +114,11 @@ export class AuthorizationLists {
+                 }
+                 const chainId = hexToBytes(item.chainId);
+                 const addressBytes = hexToBytes(item.address);
+-                const nonceList = [];
+-                for (let j = 0; j < item.nonce.length; j++) {
+-                    nonceList.push(hexToBytes(item.nonce[j]));
+-                }
++                const nonce = hexToBytes(item.nonce);
+                 const yParity = hexToBytes(item.yParity);
+                 const r = hexToBytes(item.r);
+                 const s = hexToBytes(item.s);
+-                newAuthorizationList.push([chainId, addressBytes, nonceList, yParity, r, s]);
++                newAuthorizationList.push([chainId, addressBytes, nonce, yParity, r, s]);
+             }
+             bufferAuthorizationList = newAuthorizationList;
+         }
+@@ -133,18 +130,14 @@ export class AuthorizationLists {
+                 const data = bufferAuthorizationList[i];
+                 const chainId = bytesToHex(data[0]);
+                 const address = bytesToHex(data[1]);
+-                const nonces = data[2];
+-                const nonceList = [];
+-                for (let j = 0; j < nonces.length; j++) {
+-                    nonceList.push(bytesToHex(nonces[j]));
+-                }
++                const nonce = bytesToHex(data[2]);
+                 const yParity = bytesToHex(data[3]);
+                 const r = bytesToHex(data[4]);
+                 const s = bytesToHex(data[5]);
+                 const jsonItem = {
+                     chainId,
+                     address,
+-                    nonce: nonceList,
++                    nonce,
+                     yParity,
+                     r,
+                     s,
+@@ -162,20 +155,14 @@ export class AuthorizationLists {
+         for (let key = 0; key < authorizationList.length; key++) {
+             const authorizationListItem = authorizationList[key];
+             const address = authorizationListItem[1];
+-            const nonceList = authorizationListItem[2];
++            const nonce = authorizationListItem[2];
+             const yParity = authorizationListItem[3];
+             const r = authorizationListItem[4];
+             const s = authorizationListItem[5];
+-            validateNoLeadingZeroes({ yParity, r, s });
++            validateNoLeadingZeroes({ yParity, r, s, nonce });
+             if (address.length !== 20) {
+                 throw new Error('Invalid EIP-7702 transaction: address length should be 20 bytes');
+             }
+-            if (nonceList.length > 1) {
+-                throw new Error('Invalid EIP-7702 transaction: nonce list should consist of at most 1 item');
+-            }
+-            else if (nonceList.length === 1) {
+-                validateNoLeadingZeroes({ nonce: nonceList[0] });
+-            }
+         }
+     }
+     static getDataFeeEIP7702(authorityList, common) {

.yarn/patches/@metamask-transaction-controller-npm-45.0.0-010fef9da6.patch

@@ -1,4 +1,7 @@
-import { AccountsControllerGetSelectedAccountAction } from '@metamask/accounts-controller';
+import {
+  AccountsControllerGetSelectedAccountAction,
+  AccountsControllerGetStateAction,
+} from '@metamask/accounts-controller';
 import { ApprovalControllerActions } from '@metamask/approval-controller';
 import { Messenger } from '@metamask/base-controller';
 import {
@@ -21,6 +24,8 @@ import {
   TransactionControllerUnapprovedTransactionAddedEvent,
 } from '@metamask/transaction-controller';
 import { SmartTransactionsControllerSmartTransactionEvent } from '@metamask/smart-transactions-controller';
+import { RemoteFeatureFlagControllerGetStateAction } from '@metamask/remote-feature-flag-controller';
+import { KeyringControllerSignEip7702AuthorizationAction } from '@metamask/keyring-controller';
 import {
   SwapsControllerSetApproveTxIdAction,
   SwapsControllerSetTradeTxIdAction,
@@ -29,9 +34,12 @@ import {
 type MessengerActions =
   | ApprovalControllerActions
   | AccountsControllerGetSelectedAccountAction
+  | AccountsControllerGetStateAction
+  | KeyringControllerSignEip7702AuthorizationAction
   | NetworkControllerFindNetworkClientIdByChainIdAction
   | NetworkControllerGetEIP1559CompatibilityAction
   | NetworkControllerGetNetworkClientByIdAction
+  | RemoteFeatureFlagControllerGetStateAction
   | SwapsControllerSetApproveTxIdAction
   | SwapsControllerSetTradeTxIdAction;
 
@@ -60,9 +68,12 @@ export function getTransactionControllerMessenger(
     name: 'TransactionController',
     allowedActions: [
       'AccountsController:getSelectedAccount',
+      'AccountsController:getState',
       `ApprovalController:addRequest`,
+      'KeyringController:signEip7702Authorization',
       'NetworkController:findNetworkClientIdByChainId',
       'NetworkController:getNetworkClientById',
+      'RemoteFeatureFlagController:getState',
     ],
     allowedEvents: [`NetworkController:stateChange`],
   });
@@ -92,6 +103,7 @@ export function getTransactionControllerInitMessenger(
       'ApprovalController:startFlow',
       'ApprovalController:updateRequestState',
       'NetworkController:getEIP1559Compatibility',
+      'RemoteFeatureFlagController:getState',
       'SwapsController:setApproveTxId',
       'SwapsController:setTradeTxId',
     ],

app/scripts/controller-init/messengers/transaction-controller-messenger.ts

@@ -153,10 +153,13 @@ export const unrestrictedMethods = Object.freeze([
   'personal_ecRecover',
   'personal_sign',
   'wallet_addEthereumChain',
+  'wallet_getCallsStatus',
+  'wallet_getCapabilities',
   'wallet_getPermissions',
   'wallet_requestPermissions',
   'wallet_revokePermissions',
   'wallet_registerOnboarding',
+  'wallet_sendCalls',
   'wallet_switchEthereumChain',
   'wallet_watchAsset',
   'web3_clientVersion',

app/scripts/controllers/permissions/specifications.js

@@ -11,13 +11,16 @@ import {
 export default function createMetamaskMiddleware({
   version,
   getAccounts,
+  getCapabilities,
+  getTransactionReceiptsByBatchId,
   processTransaction,
   processTypedMessage,
   processTypedMessageV3,
   processTypedMessageV4,
   processPersonalMessage,
   processDecryptMessage,
   processEncryptionPublicKey,
+  processSendCalls,
   getPendingNonce,
   getPendingTransactionByHash,
 }) {
@@ -28,13 +31,16 @@ export default function createMetamaskMiddleware({
     }),
     createWalletMiddleware({
       getAccounts,
+      getCapabilities,
+      getTransactionReceiptsByBatchId,
       processTransaction,
       processTypedMessage,
       processTypedMessageV3,
       processTypedMessageV4,
       processPersonalMessage,
       processDecryptMessage,
       processEncryptionPublicKey,
+      processSendCalls,
     }),
     createPendingNonceMiddleware({ getPendingNonce }),
     createPendingTxMiddleware({ getPendingTransactionByHash }),