Address PR review

Author: pedronfigueiredo

ui/pages/confirmations/components/confirm/info/approve/approve-static-simulation/approve-static-simulation.tsx

@@ -27,15 +27,13 @@ export const ApproveStaticSimulation = () => {
   const { currentConfirmation: transactionMeta } =
     useConfirmContext<TransactionMeta>();
 
-  const { decimals: initialDecimals } = useAssetDetails(
+  const { decimals } = useAssetDetails(
     transactionMeta?.txParams?.to,
     transactionMeta?.txParams?.from,
     transactionMeta?.txParams?.data,
     transactionMeta?.chainId,
   );
 
-  const decimals = initialDecimals || '0';
-
   const {
     spendingCap,
     isUnlimitedSpendingCap,

ui/pages/confirmations/components/confirm/info/approve/approve.tsx

@@ -35,7 +35,7 @@ const ApproveInfo = () => {
 
   const { spendingCap, pending } = useApproveTokenSimulation(
     transactionMeta,
-    decimals || '0',
+    decimals,
   );
 
   const showRevokeVariant =

ui/pages/confirmations/components/confirm/info/approve/edit-spending-cap-modal/edit-spending-cap-modal.tsx

@@ -64,7 +64,7 @@ export const EditSpendingCapModal = ({
 
   const { formattedSpendingCap, spendingCap } = useApproveTokenSimulation(
     transactionMeta,
-    decimals || '0',
+    decimals,
   );
 
   const [customSpendingCapInputValue, setCustomSpendingCapInputValue] =

ui/pages/confirmations/components/confirm/info/approve/hooks/use-approve-token-simulation.ts

@@ -18,7 +18,7 @@ function isSpendingCapUnlimited(decodedSpendingCap: number) {
 
 export const useApproveTokenSimulation = (
   transactionMeta: TransactionMeta,
-  decimals: string,
+  decimals: string | undefined,
 ) => {
   const locale = useSelector(getIntlLocale);
   const { isNFT, pending: isNFTPending } = useIsNFT(transactionMeta);
@@ -43,7 +43,7 @@ export const useApproveTokenSimulation = (
 
     return calcTokenAmount(
       value.data[0].params[paramIndex].value,
-      Number(decimals),
+      Number(decimals || '0'),
     ).toFixed();
   }, [value, decimals]);
 

ui/pages/confirmations/components/confirm/info/approve/spending-cap/spending-cap.tsx

@@ -90,10 +90,7 @@ export const SpendingCap = ({
     Number(decimals ?? '0'),
   ).toFixed();
 
-  const { pending } = useApproveTokenSimulation(
-    transactionMeta,
-    decimals || '0',
-  );
+  const { pending } = useApproveTokenSimulation(transactionMeta, decimals);
 
   if (pending) {
     return <Container isLoading />;

ui/pages/confirmations/components/confirm/title/hooks/useCurrentSpendingCap.ts

@@ -43,7 +43,7 @@ export function useCurrentSpendingCap(currentConfirmation: Confirmation) {
 
   const { spendingCap, pending } = useApproveTokenSimulation(
     currentConfirmation as TransactionMeta,
-    decimals || '0',
+    decimals,
   );
 
   let customSpendingCap = '';