Address PR review

Author: pedronfigueiredo

ui/pages/confirmations/components/confirm/info/approve/hooks/use-approve-token-simulation.ts

@@ -7,12 +7,12 @@ import { useSelector } from 'react-redux';
 import { calcTokenAmount } from '../../../../../../../../shared/lib/transactions-controller-utils';
 import { getIntlLocale } from '../../../../../../../ducks/locale/locale';
 import { formatAmount } from '../../../../simulation-details/formatAmount';
-import { UNLIMITED_THRESHOLD } from '../../constants';
 import { useDecodedTransactionData } from '../../hooks/useDecodedTransactionData';
+import { TOKEN_VALUE_UNLIMITED_THRESHOLD } from '../../shared/constants';
 import { useIsNFT } from './use-is-nft';
 
 function isSpendingCapUnlimited(decodedSpendingCap: number) {
-  return decodedSpendingCap >= UNLIMITED_THRESHOLD;
+  return decodedSpendingCap >= TOKEN_VALUE_UNLIMITED_THRESHOLD;
 }
 
 export const useApproveTokenSimulation = (

ui/pages/confirmations/components/confirm/info/constants.ts

@@ -1 +1,3 @@
 export const HEX_ZERO = '0x0';
+
+export const TOKEN_VALUE_UNLIMITED_THRESHOLD = 10 ** 15;

ui/pages/confirmations/components/confirm/info/shared/constants.ts

@@ -28,7 +28,7 @@ import {
   formatAmount,
   formatAmountMaxPrecision,
 } from '../../../../../simulation-details/formatAmount';
-import { UNLIMITED_THRESHOLD } from '../../../constants';
+import { TOKEN_VALUE_UNLIMITED_THRESHOLD } from '../../../shared/constants';
 import { getAmountColors } from '../../../utils';
 
 type PermitSimulationValueDisplayParams = {
@@ -57,7 +57,7 @@ type PermitSimulationValueDisplayParams = {
   /** True if value is being debited to wallet */
   debit?: boolean;
 
-  /** Wether a large amount can be substituted by "Unlimited" */
+  /** Whether a large amount can be substituted by "Unlimited" */
   canDisplayValueAsUnlimited?: boolean;
 };
 
@@ -110,7 +110,8 @@ const PermitSimulationValueDisplay: React.FC<
         tokenValue: formatAmount('en-US', tokenAmount),
         tokenValueMaxPrecision: formatAmountMaxPrecision('en-US', tokenAmount),
         shouldShowUnlimitedValue:
-          canDisplayValueAsUnlimited && Number(value) > UNLIMITED_THRESHOLD,
+          canDisplayValueAsUnlimited &&
+          Number(value) > TOKEN_VALUE_UNLIMITED_THRESHOLD,
       };
     }, [tokenDecimals, value]);