Use gasLimitNoBuffer on network fee estimation

Author: OGPoyraz

package.json

@@ -249,7 +249,8 @@
     "secp256k1@npm:^4.0.0": "4.0.4",
     "secp256k1@npm:^4.0.1": "4.0.4",
     "secp256k1@npm:4.0.2": "4.0.4",
-    "secp256k1@npm:4.0.3": "4.0.4"
+    "secp256k1@npm:4.0.3": "4.0.4",
+    "@metamask/transaction-controller@npm:^42.1.0": "npm:@metamask-previews/[email protected]"
   },
   "dependencies": {
     "@babel/runtime": "patch:@babel/runtime@npm%3A7.25.9#~/.yarn/patches/@babel-runtime-npm-7.25.9-fe8c62510a.patch",

ui/pages/confirmations/components/confirm/info/hooks/useFeeCalculations.test.ts

@@ -65,6 +65,37 @@ describe('useFeeCalculations', () => {
     `);
   });
 
+  it('picks up gasLimitNoBuffer for minimum network fee on estimations', () => {
+    const transactionMeta = genUnapprovedContractInteractionConfirmation({
+      address: CONTRACT_INTERACTION_SENDER_ADDRESS,
+    }) as TransactionMeta;
+
+    // txParams.gas is 0xab77
+    transactionMeta.gasLimitNoBuffer = '0x9b77';
+
+    const { result } = renderHookWithProvider(
+      () => useFeeCalculations(transactionMeta),
+      mockState,
+    );
+
+    expect(result.current).toMatchInlineSnapshot(`
+      {
+        "estimatedFeeFiat": "$0.03",
+        "estimatedFeeFiatWith18SignificantDigits": null,
+        "estimatedFeeNative": "0.0001 ETH",
+        "l1FeeFiat": "",
+        "l1FeeFiatWith18SignificantDigits": "",
+        "l1FeeNative": "",
+        "l2FeeFiat": "",
+        "l2FeeFiatWith18SignificantDigits": "",
+        "l2FeeNative": "",
+        "maxFeeFiat": "$0.07",
+        "maxFeeFiatWith18SignificantDigits": null,
+        "maxFeeNative": "0.0001 ETH",
+      }
+    `);
+  });
+
   it('returns the correct estimate for a transaction with layer1GasFee', () => {
     const transactionMeta = genUnapprovedContractInteractionConfirmation({
       address: CONTRACT_INTERACTION_SENDER_ADDRESS,

ui/pages/confirmations/components/confirm/info/hooks/useFeeCalculations.ts

@@ -157,9 +157,12 @@ export function useFeeCalculations(transactionMeta: TransactionMeta) {
       minimumFeePerGas = decimalToHex(maxFeePerGas);
     }
 
+    // We want to pick gasLimitNoBuffer to show minimum network fee
+    const minimumGasLimit = transactionMeta?.gasLimitNoBuffer || gasLimit;
+
     const estimatedFee = multiplyHexes(
       supportsEIP1559 ? (minimumFeePerGas as Hex) : (gasPrice as Hex),
-      gasLimit as Hex,
+      minimumGasLimit as Hex,
     );
 
     return getFeesFromHex(estimatedFee);

yarn.lock

@@ -6446,9 +6446,9 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@metamask/transaction-controller@npm:^42.1.0":
-  version: 42.1.0
-  resolution: "@metamask/transaction-controller@npm:42.1.0"
+"@metamask/transaction-controller@npm:@metamask-previews/transaction-controller@42.1.0-preview-981e1d0":
+  version: 42.1.0-preview-981e1d0
+  resolution: "@metamask-previews/transaction-controller@npm:42.1.0-preview-981e1d0"
   dependencies:
     "@ethereumjs/common": "npm:^3.2.0"
     "@ethereumjs/tx": "npm:^4.2.0"
@@ -6476,7 +6476,7 @@ __metadata:
     "@metamask/eth-block-tracker": ">=9"
     "@metamask/gas-fee-controller": ^22.0.0
     "@metamask/network-controller": ^22.0.0
-  checksum: 10/9f842e2b68e84cbffdda301a0e15faab08226fd8e22eb954690ed41df60fe92c24acffdd9186b4c9f1da911a368cbe22cdb9ee046fc02d079c53f76100c66755
+  checksum: 10/55f79c9e3596f9c70e014159cb8d125fedaae82e944b9004fa9d64118d825c7ffebabdada6da63f2a2b4260a59322e3bbece0d782e1f1d70e2a64c5b29c1a279
   languageName: node
   linkType: hard