Skip to content

Commit c85f971

Browse files
danjmvinnyhoward
andauthored
chore (cherry-pick): cp-12.13.0 remove SRP video (#30586) (#30590)
Cherry pick [e957fed](e957fed) to v12.13.0 ## **Description** Removed the SRP video during wallet creation flow and replaced it with a SRP lock design [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30586?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Freshly installed app 2. Create wallet 3. Create password 4. During the wallet phrase flow you should see no video and a new design ## **Screenshots/Recordings** NA ### **Before** <img width="1840" alt="Screenshot 2025-02-26 at 10 23 07 AM" src="https://github.com/user-attachments/assets/8ddcfd34-0fe4-4b53-afaf-04dab0639876" /> ### **After** <img width="1840" alt="Screenshot 2025-02-26 at 10 23 37 AM" src="https://github.com/user-attachments/assets/3db6ea6b-4bbd-4be4-9951-ce12a35e4284" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30590?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Vince Howard <[email protected]>
1 parent af01b27 commit c85f971

39 files changed

+17
-1710
lines changed

app/_locales/de/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/el/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/en/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/en_GB/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/es/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/es_419/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/fr/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/hi/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/id/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/ja/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/ko/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/ph/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/pt/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/pt_BR/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/ru/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/tl/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/tr/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/vi/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/zh_CN/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/zh_TW/messages.json

-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/images/srp-lock-design.png

69.1 KB
Loading

app/images/videos/recovery-onboarding/subtitles/de.vtt

-98
This file was deleted.

app/images/videos/recovery-onboarding/subtitles/el.vtt

-98
This file was deleted.

0 commit comments

Comments
 (0)