Skip to content

Commit 87d2795

Browse files
FrederikBoldingGudahtt
authored andcommitted
fix: Disable MV3 for MV2 Flask production build (#25209)
## **Description** Disables MV3 for the MV2 Flask production build. This was seemingly missed when setting up the CI to build for production and caused problems with the latest build submitted to Firefox. Also updates the release script to use MV2 builds for Firefox. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25209?quickstart=1)
1 parent ee0b90d commit 87d2795

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -749,7 +749,7 @@ jobs:
749749
steps:
750750
- run:
751751
name: build:prod
752-
command: yarn build --build-type flask prod
752+
command: ENABLE_MV3=false yarn build --build-type flask prod
753753
- run:
754754
name: build:debug
755755
command: find dist/ -type f -exec md5sum {} \; | sort -k 2

.circleci/scripts/release-create-gh-release.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ then
6969
release_body="$(awk -v version="${tag##v}" -f .circleci/scripts/show-changelog.awk CHANGELOG.md)"
7070
hub release create \
7171
--attach builds/metamask-chrome-*.zip \
72-
--attach builds/metamask-firefox-*.zip \
72+
--attach builds-mv2/metamask-firefox-*.zip \
7373
--attach builds-flask/metamask-flask-chrome-*.zip \
74-
--attach builds-flask/metamask-flask-firefox-*.zip \
74+
--attach builds-flask-mv2/metamask-flask-firefox-*.zip \
7575
--attach builds-mmi/metamask-mmi-chrome-*.zip \
7676
--attach builds-mmi/metamask-mmi-firefox-*.zip \
7777
--message "Version ${tag##v}" \

0 commit comments

Comments
 (0)