feat: Convert mmi controller to a non-controller (#27983)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
We want to bring MMIController up to date with our latest controller
patterns.

After review, it turns out that MMIController does not have any state
and therefore should not inherit from BaseController (or anything, for
that matter).

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27983?quickstart=1)

## **Related issues**

Fixes: #25926 

## **Manual testing steps**

N/A

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: kanthesha

app/scripts/controllers/mmi-controller.test.ts

@@ -17,13 +17,14 @@ import {
   NETWORK_TYPES,
   TEST_NETWORK_TICKER_MAP,
 } from '../../../shared/constants/network';
-import MMIController from './mmi-controller';
+import { MMIController, AllowedActions } from './mmi-controller';
 import { AppStateController } from './app-state-controller';
 import { ControllerMessenger } from '@metamask/base-controller';
 import { mmiKeyringBuilderFactory } from '../mmi-keyring-builder-factory';
 import MetaMetricsController from './metametrics';
 import { ETH_EOA_METHODS } from '../../../shared/constants/eth-methods';
 import { mockNetworkState } from '../../../test/stub/networks';
+import { InfuraNetworkType } from '@metamask/controller-utils';
 import { API_REQUEST_LOG_EVENT } from '@metamask-institutional/sdk';
 
 jest.mock('@metamask-institutional/portfolio-dashboard', () => ({
@@ -39,6 +40,21 @@ jest.mock('./permissions', () => ({
   }),
 }));
 
+export const createMockNetworkConfiguration = (
+  override?: Partial<NetworkConfiguration>,
+): NetworkConfiguration => {
+  return {
+    chainId: CHAIN_IDS.SEPOLIA,
+    blockExplorerUrls: [],
+    defaultRpcEndpointIndex: 0,
+    name: 'Mock Network',
+    nativeCurrency: 'MOCK TOKEN',
+    rpcEndpoints: [],
+    defaultBlockExplorerUrlIndex: 0,
+    ...override,
+  };
+};
+
 const mockAccount = {
   address: '0x758b8178a9A4B7206d1f648c4a77C515Cbac7001',
   id: 'mock-id',
@@ -73,10 +89,10 @@ describe('MMIController', function () {
     mmiConfigurationController,
     controllerMessenger,
     accountsController,
-    networkController,
     keyringController,
     metaMetricsController,
-    custodyController;
+    custodyController,
+    mmiControllerMessenger;
 
   beforeEach(async function () {
     const mockMessenger = {
@@ -89,22 +105,10 @@ describe('MMIController', function () {
       subscribe: jest.fn(),
     };
 
-    networkController = new NetworkController({
-      messenger: new ControllerMessenger().getRestricted({
-        name: 'NetworkController',
-        allowedEvents: [
-          'NetworkController:stateChange',
-          'NetworkController:networkWillChange',
-          'NetworkController:networkDidChange',
-          'NetworkController:infuraIsBlocked',
-          'NetworkController:infuraIsUnblocked',
-        ],
-      }),
-      state: mockNetworkState({ chainId: CHAIN_IDS.SEPOLIA }),
-      infuraProjectId: 'mock-infura-project-id',
-    });
-
-    controllerMessenger = new ControllerMessenger();
+    const controllerMessenger = new ControllerMessenger<
+    AllowedActions,
+    never
+  >();
 
     accountsController = new AccountsController({
       messenger: controllerMessenger.getRestricted({
@@ -212,14 +216,42 @@ describe('MMIController', function () {
       onNetworkDidChange: jest.fn(),
     });
 
-    const mmiControllerMessenger = controllerMessenger.getRestricted({
+    controllerMessenger.registerActionHandler(
+      'NetworkController:getState',
+      jest.fn().mockReturnValue(mockNetworkState({ chainId: CHAIN_IDS.SEPOLIA })),
+    );
+
+    controllerMessenger.registerActionHandler(
+      'NetworkController:setActiveNetwork',
+      InfuraNetworkType['sepolia'],
+    );
+
+    controllerMessenger.registerActionHandler(
+      'NetworkController:getNetworkClientById',
+      jest.fn().mockReturnValue({
+        configuration: {
+          chainId: CHAIN_IDS.SEPOLIA,
+        }
+      }),
+    );
+
+    controllerMessenger.registerActionHandler(
+      'NetworkController:getNetworkConfigurationByChainId',
+      jest.fn().mockReturnValue(createMockNetworkConfiguration()),
+    );
+
+    mmiControllerMessenger = controllerMessenger.getRestricted({
       name: 'MMIController',
       allowedActions: [
         'AccountsController:getAccountByAddress',
         'AccountsController:setAccountName',
         'AccountsController:listAccounts',
         'AccountsController:getSelectedAccount',
         'AccountsController:setSelectedAccount',
+        'NetworkController:getState',
+        'NetworkController:setActiveNetwork',
+        'NetworkController:getNetworkClientById',
+        'NetworkController:getNetworkConfigurationByChainId'
       ],
     });
 
@@ -253,7 +285,6 @@ describe('MMIController', function () {
           })
         }
       }),
-      networkController,
       permissionController,
       custodyController,
       metaMetricsController,
@@ -507,9 +538,7 @@ describe('MMIController', function () {
       CUSTODIAN_TYPES['CUSTODIAN-TYPE'] = {
         keyringClass: { type: 'mock-keyring-class' },
       };
-      mmiController.messenger.call = jest
-        .fn()
-        .mockReturnValue({ address: '0x1' });
+      jest.spyOn(mmiControllerMessenger, 'call').mockReturnValue({ address: '0x1' });
       mmiController.custodyController.getCustodyTypeByAddress = jest
         .fn()
         .mockReturnValue('custodian-type');
@@ -628,9 +657,7 @@ describe('MMIController', function () {
       mmiController.custodyController.getAccountDetails = jest
         .fn()
         .mockReturnValue({});
-      mmiController.messenger.call = jest
-        .fn()
-        .mockReturnValue([mockAccount, mockAccount2]);
+        jest.spyOn(mmiControllerMessenger, 'call').mockReturnValue([mockAccount, mockAccount2]);
       mmiController.mmiConfigurationController.store.getState = jest
         .fn()
         .mockReturnValue({
@@ -701,7 +728,7 @@ describe('MMIController', function () {
 
   describe('handleMmiCheckIfTokenIsPresent', () => {
     it('should check if a token is present', async () => {
-      mmiController.messenger.call = jest
+      mmiController.messagingSystem.call = jest
         .fn()
         .mockReturnValue({ address: '0x1' });
       mmiController.custodyController.getCustodyTypeByAddress = jest
@@ -733,7 +760,7 @@ describe('MMIController', function () {
 
   describe('handleMmiDashboardData', () => {
     it('should return internalAccounts as identities', async () => {
-      const controllerMessengerSpy = jest.spyOn(controllerMessenger, 'call');
+      const controllerMessengerSpy = jest.spyOn(mmiControllerMessenger, 'call');
       await mmiController.handleMmiDashboardData();
 
       expect(controllerMessengerSpy).toHaveBeenCalledWith(
@@ -811,7 +838,7 @@ describe('MMIController', function () {
 
   describe('setAccountAndNetwork', () => {
     it('should set a new selected account if the selectedAddress and the address from the arguments is different', async () => {
-      const selectedAccountSpy = jest.spyOn(controllerMessenger, 'call');
+      const selectedAccountSpy = jest.spyOn(mmiControllerMessenger, 'call');
       await mmiController.setAccountAndNetwork(
         'mock-origin',
         mockAccount2.address,
@@ -829,14 +856,14 @@ describe('MMIController', function () {
     });
 
     it('should not set a new selected account the accounts are the same', async () => {
-      const selectedAccountSpy = jest.spyOn(controllerMessenger, 'call');
+      const selectedAccountSpy = jest.spyOn(mmiControllerMessenger, 'call');
       await mmiController.setAccountAndNetwork(
         'mock-origin',
         mockAccount.address,
         '0x1',
       );
 
-      expect(selectedAccountSpy).toHaveBeenCalledTimes(1);
+      expect(selectedAccountSpy).toHaveBeenCalledTimes(4);
       const selectedAccount = accountsController.getSelectedAccount();
       expect(selectedAccount.id).toBe(mockAccount.id);
     });