Skip to content

Commit 753de30

Browse files
authored
Merge pull request #1359 from MetaMask/FixBlockPolling
Fix block polling
2 parents 1641dc9 + 7ddbd1a commit 753de30

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@
22

33
## Current Master
44

5+
## 3.6.1 2017-4-25
6+
57
- Fix bug where error was reported in debugger console when Chrome opened a new window.
8+
- Fix bug where block-tracker could stop polling for new blocks.
69

710
## 3.6.0 2017-4-25
811

app/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "MetaMask",
33
"short_name": "Metamask",
4-
"version": "3.6.0",
4+
"version": "3.6.1",
55
"manifest_version": 2,
66
"author": "https://metamask.io",
77
"description": "Ethereum Browser Extension",

app/scripts/metamask-controller.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -341,9 +341,7 @@ module.exports = class MetamaskController extends EventEmitter {
341341
console.error('Error in RPC response:\n', response.error)
342342
}
343343
if (request.isMetamaskInternal) return
344-
if (global.METAMASK_DEBUG) {
345-
console.log(`RPC (${originDomain}):`, request, '->', response)
346-
}
344+
log.info(`RPC (${originDomain}):`, request, '->', response)
347345
}
348346
}
349347

@@ -591,9 +589,7 @@ module.exports = class MetamaskController extends EventEmitter {
591589

592590
// Log blocks
593591
logBlock (block) {
594-
if (global.METAMASK_DEBUG) {
595-
console.log(`BLOCK CHANGED: #${block.number.toString('hex')} 0x${block.hash.toString('hex')}`)
596-
}
592+
log.info(`BLOCK CHANGED: #${block.number.toString('hex')} 0x${block.hash.toString('hex')}`)
597593
this.verifyNetwork()
598594
}
599595

@@ -682,9 +678,7 @@ module.exports = class MetamaskController extends EventEmitter {
682678
this.setNetworkState('loading')
683679
return
684680
}
685-
if (global.METAMASK_DEBUG) {
686-
console.log('web3.getNetwork returned ' + network)
687-
}
681+
log.info('web3.getNetwork returned ' + network)
688682
this.setNetworkState(network)
689683
})
690684
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@
119119
"valid-url": "^1.0.9",
120120
"vreme": "^3.0.2",
121121
"web3": "0.18.2",
122-
"web3-provider-engine": "^12.0.2",
122+
"web3-provider-engine": "^12.0.3",
123123
"web3-stream-provider": "^2.0.6",
124124
"xtend": "^4.0.1"
125125
},

0 commit comments

Comments
 (0)