fix: Missing Unlimited as value for the DAI permit

pedronfigueiredo · pedronfigueiredo · commit 6c106c22b20e · 2025-01-09T11:26:11.000Z
diff --git a/test/integration/confirmations/signatures/permit-batch.test.tsx b/test/integration/confirmations/signatures/permit-batch.test.tsx
@@ -100,12 +100,12 @@ describe('Permit Batch Signature Tests', () => {
 
     const simulationDetails = [
       'Estimated changes',
-      "You're giving the spender permission to spend this many tokens from your account.",
+      "You're removing the spender permission to spend this many tokens from your account.",
       'Spending cap',
       '0xA0b86...6eB48',
-      '1,461,501,637,3...',
+      'Unlimited',
       '0xb0B86...6EB48',
-      '2,461,501,637,3...',
+      'Unlimited',
     ];
 
     verifyDetails(simulationSection, simulationDetails);
diff --git a/test/integration/confirmations/signatures/permit-single.test.tsx b/test/integration/confirmations/signatures/permit-single.test.tsx
@@ -98,10 +98,10 @@ describe('Permit Single Signature Tests', () => {
     );
     const simulationDetails = [
       'Estimated changes',
-      "You're giving the spender permission to spend this many tokens from your account.",
+      "You're removing the spender permission to spend this many tokens from your account.",
       'Spending cap',
       '0xA0b86...6eB48',
-      '1,461,501,637,3...',
+      'Unlimited',
     ];
 
     expect(simulationSection).toBeInTheDocument();
diff --git a/test/integration/confirmations/signatures/permit.test.tsx b/test/integration/confirmations/signatures/permit.test.tsx
@@ -235,7 +235,7 @@ describe('Permit Confirmation', () => {
     expect(simulationSection).toBeInTheDocument();
     expect(simulationSection).toHaveTextContent('Estimated changes');
     expect(simulationSection).toHaveTextContent(
-      "You're giving the spender permission to spend this many tokens from your account.",
+      "You're removing the spender permission to spend this many tokens from your account.",
     );
     expect(simulationSection).toHaveTextContent('Spending cap');
     expect(simulationSection).toHaveTextContent('0xCcCCc...ccccC');
diff --git a/ui/components/app/snaps/snap-ui-address/__snapshots__/snap-ui-address.test.tsx.snap b/ui/components/app/snaps/snap-ui-address/__snapshots__/snap-ui-address.test.tsx.snap
@@ -172,7 +172,7 @@ exports[`SnapUIAddress renders Ethereum address 1`] = `
           <rect
             fill="#F29602"
             height="32"
-            transform="translate(-2.81750896228304 4.951916544006229) rotate(230.4 16 16)"
+            transform="translate(-2.8175089622830405 4.951916544006229) rotate(230.4 16 16)"
             width="32"
             x="0"
             y="0"
@@ -476,7 +476,7 @@ exports[`SnapUIAddress renders legacy Ethereum address 1`] = `
           <rect
             fill="#F29602"
             height="32"
-            transform="translate(-2.81750896228304 4.951916544006229) rotate(230.4 16 16)"
+            transform="translate(-2.8175089622830405 4.951916544006229) rotate(230.4 16 16)"
             width="32"
             x="0"
             y="0"
diff --git a/ui/components/multichain/connect-accounts-modal/__snapshots__/connect-accounts-modal.test.tsx.snap b/ui/components/multichain/connect-accounts-modal/__snapshots__/connect-accounts-modal.test.tsx.snap
@@ -159,7 +159,7 @@ exports[`Connect More Accounts Modal should render correctly 1`] = `
                                 <rect
                                   fill="#FA4300"
                                   height="32"
-                                  transform="translate(-1.712066926084717 -0.6920409130150889) rotate(264.3 16 16)"
+                                  transform="translate(-1.712066926084717 -0.6920409130150887) rotate(264.3 16 16)"
                                   width="32"
                                   x="0"
                                   y="0"
@@ -202,7 +202,7 @@ exports[`Connect More Accounts Modal should render correctly 1`] = `
                                 <rect
                                   fill="#FA4300"
                                   height="32"
-                                  transform="translate(-1.712066926084717 -0.6920409130150889) rotate(264.3 16 16)"
+                                  transform="translate(-1.712066926084717 -0.6920409130150887) rotate(264.3 16 16)"
                                   width="32"
                                   x="0"
                                   y="0"
@@ -261,7 +261,7 @@ exports[`Connect More Accounts Modal should render correctly 1`] = `
                         <rect
                           fill="#FA4300"
                           height="32"
-                          transform="translate(-1.712066926084717 -0.6920409130150889) rotate(264.3 16 16)"
+                          transform="translate(-1.712066926084717 -0.6920409130150887) rotate(264.3 16 16)"
                           width="32"
                           x="0"
                           y="0"
@@ -304,7 +304,7 @@ exports[`Connect More Accounts Modal should render correctly 1`] = `
                         <rect
                           fill="#FA4300"
                           height="32"
-                          transform="translate(-1.712066926084717 -0.6920409130150889) rotate(264.3 16 16)"
+                          transform="translate(-1.712066926084717 -0.6920409130150887) rotate(264.3 16 16)"
                           width="32"
                           x="0"
                           y="0"
diff --git a/ui/pages/confirmations/components/confirm/info/typed-sign/__snapshots__/typed-sign.test.tsx.snap b/ui/pages/confirmations/components/confirm/info/typed-sign/__snapshots__/typed-sign.test.tsx.snap
@@ -45,7 +45,7 @@ exports[`TypedSignInfo correctly renders permit sign type 1`] = `
           class="mm-box mm-text mm-text--body-md mm-box--color-inherit"
           style="white-space: pre-wrap;"
         >
-          You're giving the spender permission to spend this many tokens from your account.
+          You're removing the spender permission to spend this many tokens from your account.
         </p>
       </div>
     </div>
@@ -420,7 +420,7 @@ exports[`TypedSignInfo correctly renders permit sign type with no deadline 1`] =
           class="mm-box mm-text mm-text--body-md mm-box--color-inherit"
           style="white-space: pre-wrap;"
         >
-          You're giving the spender permission to spend this many tokens from your account.
+          You're removing the spender permission to spend this many tokens from your account.
         </p>
       </div>
     </div>
diff --git a/ui/pages/confirmations/components/confirm/info/typed-sign/typed-sign-v4-simulation/permit-simulation/__snapshots__/permit-simulation.test.tsx.snap b/ui/pages/confirmations/components/confirm/info/typed-sign/typed-sign-v4-simulation/permit-simulation/__snapshots__/permit-simulation.test.tsx.snap
@@ -45,7 +45,7 @@ exports[`PermitSimulation renders component correctly 1`] = `
           class="mm-box mm-text mm-text--body-md mm-box--color-inherit"
           style="white-space: pre-wrap;"
         >
-          You're giving the spender permission to spend this many tokens from your account.
+          You're removing the spender permission to spend this many tokens from your account.
         </p>
       </div>
     </div>
diff --git a/ui/pages/confirmations/components/confirm/info/typed-sign/typed-sign-v4-simulation/permit-simulation/permit-simulation.tsx b/ui/pages/confirmations/components/confirm/info/typed-sign/typed-sign-v4-simulation/permit-simulation/permit-simulation.tsx
@@ -107,17 +107,20 @@ const PermitSimulation: React.FC<object> = () => {
     </ConfirmInfoRow>
   );
 
+  let descriptionKey;
+  if (isNFT) {
+    descriptionKey = 'simulationDetailsApproveDesc';
+  } else if (message.allowed === true) {
+    descriptionKey = 'permitSimulationDetailInfo';
+  } else {
+    descriptionKey = 'permitRevokeSimulationDetailInfo';
+  }
+
   return (
     <StaticSimulation
       title={t('simulationDetailsTitle')}
       titleTooltip={t('simulationDetailsTitleTooltip')}
-      description={t(
-        isNFT
-          ? 'simulationDetailsApproveDesc'
-          : message.allowed === true
-          ? 'permitSimulationDetailInfo'
-          : 'permitRevokeSimulationDetailInfo',
-      )}
+      description={t(descriptionKey)}
       simulationElements={SpendingCapRow}
     />
   );
diff --git a/ui/pages/confirmations/components/confirm/info/typed-sign/typed-sign-v4-simulation/typed-sign-v4-simulation.test.tsx b/ui/pages/confirmations/components/confirm/info/typed-sign/typed-sign-v4-simulation/typed-sign-v4-simulation.test.tsx
@@ -68,7 +68,7 @@ describe('PermitSimulation', () => {
       expect(await findByText('Estimated changes')).toBeInTheDocument();
       expect(
         await findByText(
-          "You're giving the spender permission to spend this many tokens from your account.",
+          "You're removing the spender permission to spend this many tokens from your account.",
         ),
       ).toBeInTheDocument();
     });
@@ -103,7 +103,7 @@ describe('PermitSimulation', () => {
       expect(await findByText('Estimated changes')).toBeInTheDocument();
       expect(
         await findByText(
-          "You're giving the spender permission to spend this many tokens from your account.",
+          "You're removing the spender permission to spend this many tokens from your account.",
         ),
       ).toBeInTheDocument();
     });
diff --git a/ui/pages/confirmations/confirm/__snapshots__/confirm.test.tsx.snap b/ui/pages/confirmations/confirm/__snapshots__/confirm.test.tsx.snap
diff --git a/ui/pages/confirmations/confirm/confirm.test.tsx b/ui/pages/confirmations/confirm/confirm.test.tsx

Original file line number	Diff line number	Diff line change
@@ -45,7 +45,7 @@ exports[`PermitSimulation renders component correctly 1`] = `
`45`	`45`	`class="mm-box mm-text mm-text--body-md mm-box--color-inherit"`
`46`	`46`	`style="white-space: pre-wrap;"`
`47`	`47`	`>`
`48`		`- You're giving the spender permission to spend this many tokens from your account.`
	`48`	`+ You're removing the spender permission to spend this many tokens from your account.`
`49`	`49`	`</p>`
`50`	`50`	`</div>`
`51`	`51`	`</div>`