fix: fix PR comments

Author: salimtb

app/scripts/controller-init/messengers/index.ts

@@ -23,6 +23,7 @@ import {
   getMultichainAssetsControllerMessenger,
   getMultiChainAssetsRatesControllerMessenger,
 } from './multichain';
+import { noop } from 'lodash';
 
 export const CONTROLLER_MESSENGERS = {
   CronjobController: {
@@ -42,6 +43,7 @@ export const CONTROLLER_MESSENGERS = {
   },
   MultiChainAssetsRatesController: {
     getMessenger: getMultiChainAssetsRatesControllerMessenger,
+    getInitMessenger: noop,
   },
   RateLimitController: {
     getMessenger: getRateLimitControllerMessenger,

app/scripts/controller-init/multichain/multichain-rates-assets-controller-init.test.ts

@@ -20,6 +20,7 @@ function buildInitRequestMock(): jest.Mocked<
     controllerMessenger: getMultiChainAssetsRatesControllerMessenger(
       baseControllerMessenger,
     ),
+    initMessenger: undefined,
   };
 }
 

ui/selectors/assets.test.ts

@@ -0,0 +1,93 @@
+import {
+  getAssetsRates,
+  AssetsRatesState,
+  AssetsState,
+  getAccountAssets,
+  getAssetsMetadata,
+} from './assets';
+
+const mockRatesState = {
+  metamask: {
+    conversionRates: {
+      'token-1': { rate: 1.5, currency: 'USD' },
+      'token-2': { rate: 0.8, currency: 'EUR' },
+    },
+  },
+};
+
+// Mock state for testing
+const mockAssetsState: AssetsState = {
+  metamask: {
+    accountsAssets: {
+      '5132883f-598e-482c-a02b-84eeaa352f5b': [
+        'solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/slip44:501',
+      ],
+    },
+    assetsMetadata: {
+      'solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/slip44:501': {
+        name: 'Token 1',
+        symbol: 'TKN1',
+        iconUrl: 'https://example.com/token-1.png',
+        fungible: true,
+        units: [{ symbol: 'TKN1', name: 'Token 1', decimals: 9 }],
+      },
+    },
+  },
+};
+
+describe('getAccountAssets', () => {
+  it('should return the assets from the state', () => {
+    const result = getAccountAssets(mockAssetsState);
+    expect(result).toEqual(mockAssetsState.metamask.accountsAssets);
+  });
+
+  it('should return an empty object if accountAssets is empty', () => {
+    const emptyState: AssetsState = {
+      // @ts-expect-error
+      metamask: { accountsAssets: {} },
+    };
+    const result = getAccountAssets(emptyState);
+    expect(result).toEqual({});
+  });
+});
+
+describe('getAssetsMetadata', () => {
+  it('should return the assets metadata from the state', () => {
+    const result = getAssetsMetadata(mockAssetsState);
+    expect(result).toEqual(mockAssetsState.metamask.assetsMetadata);
+  });
+
+  it('should return an empty object if assetsMetadata is empty', () => {
+    const emptyState: AssetsState = {
+      // @ts-expect-error
+      metamask: { assetsMetadata: {} },
+    };
+    const result = getAssetsMetadata(emptyState);
+    expect(result).toEqual({});
+  });
+
+  it('should return undefined if state does not have metamask property', () => {
+    const invalidState = {} as AssetsState;
+    expect(() => getAssetsMetadata(invalidState)).toThrow();
+  });
+});
+
+describe('getAssetsRates', () => {
+  it('should return the assetsRates from the state', () => {
+    const result = getAssetsRates(mockRatesState);
+    expect(result).toEqual(mockRatesState.metamask.conversionRates);
+  });
+
+  it('should return an empty object if assetsRates is empty', () => {
+    const emptyState: AssetsRatesState = {
+      metamask: { conversionRates: {} },
+    };
+    const result = getAssetsRates(emptyState);
+    expect(result).toEqual({});
+  });
+
+  it('should return undefined if state does not have metamask property', () => {
+    const invalidState = {} as AssetsRatesState;
+    expect(() => getAssetsRates(invalidState)).toThrow();
+  });
+});

ui/selectors/assets.ts

@@ -1,9 +1,16 @@
-import { MultichainAssetsControllerState } from '@metamask/assets-controllers';
+import {
+  MultichainAssetsControllerState,
+  MultichainAssetsRatesControllerState,
+} from '@metamask/assets-controllers';
 
 export type AssetsState = {
   metamask: MultichainAssetsControllerState;
 };
 
+export type AssetsRatesState = {
+  metamask: MultichainAssetsRatesControllerState;
+};
+
 /**
  * Gets non-EVM accounts assets.
  *
@@ -23,3 +30,13 @@ export function getAccountAssets(state: AssetsState) {
 export function getAssetsMetadata(state: AssetsState) {
   return state.metamask.assetsMetadata;
 }
+
+/**
+ * Gets non-EVM accounts assets rates.
+ *
+ * @param state - Redux state object.
+ * @returns An object containing non-EVM assets per accounts.
+ */
+export function getAssetsRates(state: AssetsRatesState) {
+  return state.metamask.conversionRates;
+}