Skip to content

Commit 3fe78b1

Browse files
racitoresdbrans
authored andcommitted
test: MMQA-188: remove mmi e2e tests from ci (#29233)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> MMI e2e tests are not longer maintained so they need to be removed from ci: - Remove CI (only this in this PR due to the urgency of the change) Create a new PR to remove the next points: - Remove Docs - **node dependencies** - Remove e2e/tests - Remove e2e/tests/playwright - Remove references in scripts - Remove stuff not in the code base like https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/116332/workflows/e18a49f4-f111-4728-abc8-23d46b93feb6/jobs/4357634 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29233?quickstart=1) Fixes: 1. Go to this page... 2. 3. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 317a69c commit 3fe78b1

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

.circleci/config.yml

-3
Original file line numberDiff line numberDiff line change
@@ -1349,9 +1349,6 @@ jobs:
13491349
- run:
13501350
name: Publish Flask MV2 release to Sentry
13511351
command: yarn sentry:publish --build-type flask --dist mv2
1352-
- run:
1353-
name: Publish MMI release to Sentry
1354-
command: yarn sentry:publish --build-type mmi
13551352
- run:
13561353
name: Create GitHub release
13571354
command: .circleci/scripts/release-create-gh-release.sh

.circleci/scripts/release-create-gh-release.sh

-4
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ if [[ $current_commit_msg =~ Version[-[:space:]](v[[:digit:]]+.[[:digit:]]+.[[:d
6161
then
6262
tag="${BASH_REMATCH[1]}"
6363
flask_version="$(print_build_version 'flask')"
64-
mmi_version="$(print_build_version 'mmi')"
6564

6665
install_github_cli
6766

@@ -72,15 +71,12 @@ then
7271
--attach builds-mv2/metamask-firefox-*.zip \
7372
--attach builds-flask/metamask-flask-chrome-*.zip \
7473
--attach builds-flask-mv2/metamask-flask-firefox-*.zip \
75-
--attach builds-mmi/metamask-mmi-chrome-*.zip \
76-
--attach builds-mmi/metamask-mmi-firefox-*.zip \
7774
--message "Version ${tag##v}" \
7875
--message "$release_body" \
7976
--commitish "$CIRCLE_SHA1" \
8077
"$tag"
8178

8279
publish_tag 'Flask' "${flask_version}"
83-
publish_tag 'MMI' "${mmi_version}"
8480
else
8581
printf '%s\n' 'Version not found in commit message; skipping GitHub Release'
8682
exit 0

0 commit comments

Comments
 (0)