Address PR review

Author: pedronfigueiredo

ui/pages/confirmations/components/confirm/info/approve/hooks/use-approve-token-simulation.ts

@@ -7,11 +7,10 @@ import { useSelector } from 'react-redux';
 import { calcTokenAmount } from '../../../../../../../../shared/lib/transactions-controller-utils';
 import { getIntlLocale } from '../../../../../../../ducks/locale/locale';
 import { formatAmount } from '../../../../simulation-details/formatAmount';
+import { UNLIMITED_THRESHOLD } from '../../constants';
 import { useDecodedTransactionData } from '../../hooks/useDecodedTransactionData';
 import { useIsNFT } from './use-is-nft';
 
-export const UNLIMITED_THRESHOLD = 10 ** 15;
-
 function isSpendingCapUnlimited(decodedSpendingCap: number) {
   return decodedSpendingCap >= UNLIMITED_THRESHOLD;
 }

ui/pages/confirmations/components/confirm/info/constants.ts

@@ -0,0 +1 @@
+export const UNLIMITED_THRESHOLD = 10 ** 15;

ui/pages/confirmations/components/confirm/info/typed-sign/typed-sign-v4-simulation/value-display/value-display.tsx

@@ -28,7 +28,7 @@ import {
   formatAmount,
   formatAmountMaxPrecision,
 } from '../../../../../simulation-details/formatAmount';
-import { UNLIMITED_THRESHOLD } from '../../../approve/hooks/use-approve-token-simulation';
+import { UNLIMITED_THRESHOLD } from '../../../constants';
 import { getAmountColors } from '../../../utils';
 
 type PermitSimulationValueDisplayParams = {
@@ -109,7 +109,8 @@ const PermitSimulationValueDisplay: React.FC<
       return {
         tokenValue: formatAmount('en-US', tokenAmount),
         tokenValueMaxPrecision: formatAmountMaxPrecision('en-US', tokenAmount),
-        shouldShowUnlimitedValue: Number(value) > UNLIMITED_THRESHOLD,
+        shouldShowUnlimitedValue:
+          canDisplayValueAsUnlimited && Number(value) > UNLIMITED_THRESHOLD,
       };
     }, [tokenDecimals, value]);
 
@@ -150,7 +151,7 @@ const PermitSimulationValueDisplay: React.FC<
             >
               {credit && '+ '}
               {debit && '- '}
-              {canDisplayValueAsUnlimited && shouldShowUnlimitedValue
+              {shouldShowUnlimitedValue
                 ? t('unlimited')
                 : tokenValue !== null &&
                   shortenString(tokenValue || '', {