Fix incorrect unlimited

Author: matthewwalsh0

ui/pages/confirmations/components/confirm/info/approve/hooks/use-approve-token-simulation.test.ts

@@ -33,6 +33,12 @@ describe('isSpendingCapUnlimited', () => {
       false,
     );
   });
+
+  it('returns false if spending cap is less than threshold after applying decimals', () => {
+    expect(isSpendingCapUnlimited(TOKEN_VALUE_UNLIMITED_THRESHOLD, 1)).toBe(
+      false,
+    );
+  });
 });
 
 describe('useApproveTokenSimulation', () => {

ui/pages/confirmations/components/confirm/info/approve/hooks/use-approve-token-simulation.ts

@@ -10,8 +10,12 @@ import { TOKEN_VALUE_UNLIMITED_THRESHOLD } from '../../shared/constants';
 import { parseApprovalTransactionData } from '../../../../../../../../shared/modules/transaction.utils';
 import { useIsNFT } from './use-is-nft';
 
-export function isSpendingCapUnlimited(decodedSpendingCap: number) {
-  return decodedSpendingCap >= TOKEN_VALUE_UNLIMITED_THRESHOLD;
+export function isSpendingCapUnlimited(
+  value: number | string | BigNumber,
+  decimals: number = 0,
+) {
+  const finalValue = calcTokenAmount(value, decimals);
+  return finalValue.gte(TOKEN_VALUE_UNLIMITED_THRESHOLD);
 }
 
 export const useApproveTokenSimulation = (

ui/pages/confirmations/components/confirm/info/hooks/useBatchApproveBalanceChanges.ts

@@ -120,7 +120,11 @@ async function buildSimulationTokenBalanceChanges({
     const tokenId = isNFT && amountOrTokenId ? amountOrTokenIdHex : undefined;
 
     const isUnlimited =
-      !isNFT && isSpendingCapUnlimited(amountOrTokenId?.toNumber() ?? 0);
+      !isNFT &&
+      isSpendingCapUnlimited(
+        amountOrTokenId?.toNumber() ?? 0,
+        Number(tokenData?.decimals ?? 0),
+      );
 
     const balanceChange: ApprovalSimulationBalanceChange = {
       address: tokenAddress,