Skip to content

Commit 2a78f64

Browse files
authored
fix: capture only local ppom errors (#29702)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR refines error handling by limiting the capture of errors to those occurring within the local PPOM, reducing unnecessary noise. Errors from the API are already tracked through observability tools, ensuring a more streamlined and focused error reporting process. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29702?quickstart=1) ## **Related issues** Fixes: #28767 ## **Manual testing steps** 1. Go to the test dapp 2. Click on one of the buttons in `PPOM - Malicious Transactions and Signatures` section 3. API should perform the validation as normal ## **Screenshots/Recordings** [Screencast from 2025-01-14 16-00-47.webm](https://github.com/user-attachments/assets/f1a3cf62-fbf9-4711-94bc-de37a7b0d67b) <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 8ac2116 commit 2a78f64

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

app/scripts/lib/ppom/ppom-util.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,9 @@ export function handlePPOMError(
139139
const errorData = getErrorData(error);
140140
const description = getErrorMessage(error);
141141

142-
sentry?.captureException(error);
142+
if (source === SecurityAlertSource.Local) {
143+
sentry?.captureException(error);
144+
}
143145
console.error(logMessage, errorData);
144146

145147
return {

0 commit comments

Comments
 (0)