Skip to content

Commit 2751a0d

Browse files
authored
chore: retain src input amount after switching tokens (#29709)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29709?quickstart=1) ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1798 ## **Manual testing steps** 1. Load bridge page 2. Select amount, src token and dest token 3. Click token switch button to swap src and dest selections 4. Verify that src amount is preserved ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** Amount is cleared ### **After** Amount is preserved <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 582ec93 commit 2751a0d

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

ui/pages/bridge/prepare/prepare-bridge-page.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,6 @@ const PrepareBridgePage = () => {
489489
: undefined;
490490
toChainClientId && dispatch(setActiveNetwork(toChainClientId));
491491
dispatch(setFromToken(toToken));
492-
dispatch(setFromTokenInputValue(null));
493492
fromChain?.chainId && dispatch(setToChain(fromChain.chainId));
494493
fromChain?.chainId && dispatch(setToChainId(fromChain.chainId));
495494
dispatch(setToToken(fromToken));

0 commit comments

Comments
 (0)