update controller

Author: kanthesha

app/scripts/controllers/app-state-controller.test.ts

@@ -353,7 +353,7 @@ describe('AppStateController', () => {
 
   describe('setFirstTimeUsedNetwork', () => {
     it('updates the array of the first time used networks', () => {
-      const chainId: string = '0x1';
+      const chainId = '0x1';
 
       appStateController.setFirstTimeUsedNetwork(chainId);
       expect(appStateController.store.getState().usedNetworks[chainId]).toBe(
@@ -364,11 +364,7 @@ describe('AppStateController', () => {
 
   describe('setLastInteractedConfirmationInfo', () => {
     it('sets information about last confirmation user has interacted with', () => {
-      const lastInteractedConfirmationInfo: {
-        id: string;
-        chainId: string;
-        timestamp: number;
-      } = {
+      const lastInteractedConfirmationInfo = {
         id: '123',
         chainId: '0x1',
         timestamp: new Date().getTime(),
@@ -414,7 +410,7 @@ describe('AppStateController', () => {
         'updateState',
       );
 
-      const mockParams: { url: string; oldRefreshToken: string } = {
+      const mockParams = {
         url: 'https://example.com',
         oldRefreshToken: 'old',
       };
@@ -436,7 +432,7 @@ describe('AppStateController', () => {
         'updateState',
       );
 
-      const mockParams: { fromAddress: string; custodyId: string } = {
+      const mockParams = {
         fromAddress: '0x',
         custodyId: 'custodyId',
       };
@@ -458,7 +454,7 @@ describe('AppStateController', () => {
         'updateState',
       );
 
-      const mockParams: string = 'some message';
+      const mockParams = 'some message';
 
       appStateController.setNoteToTraderMessage(mockParams);
 

app/scripts/controllers/app-state-controller.ts

@@ -25,9 +25,8 @@ import {
 import { DEFAULT_AUTO_LOCK_TIME_LIMIT } from '../../../shared/constants/preferences';
 import { LastInteractedConfirmationInfo } from '../../../shared/types/confirm';
 import { SecurityAlertSource } from '../../../shared/constants/security-provider';
-import PreferencesController, {
+import type {
   Preferences,
-  PreferencesControllerState,
   PreferencesControllerStateChangeEvent,
 } from './preferences-controller';
 
@@ -143,7 +142,9 @@ type AppStateControllerOptions = {
   isUnlocked: () => boolean;
   initState?: Partial<AppStateControllerState>;
   onInactiveTimeout?: () => void;
-  preferencesStore: ObservableStore<PreferencesControllerState>;
+  // TODO: Remove this as soon as PreferencesController upgrade to BaseControllerV2 merges with develop
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  preferencesStore: any;
   messenger: AppStateControllerMessenger;
   // TODO: Replace `any` with type
   // eslint-disable-next-line @typescript-eslint/no-explicit-any