Skip to content

Commit 1804f9e

Browse files
committed
Fix: PR comments
1 parent 29742fd commit 1804f9e

File tree

3 files changed

+15
-30
lines changed

3 files changed

+15
-30
lines changed

ui/components/app/detected-token/detected-token-details/detected-token-details.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import DetectedTokenAddress from '../detected-token-address/detected-token-addre
1414
import DetectedTokenAggregators from '../detected-token-aggregators/detected-token-aggregators';
1515
import { Display } from '../../../../helpers/constants/design-system';
1616
import {
17+
getCurrentNetwork,
1718
getTestNetworkBackgroundColor,
1819
getTokenList,
1920
} from '../../../../selectors';
@@ -28,7 +29,7 @@ const DetectedTokenDetails = ({
2829
const tokenList = useSelector(getTokenList);
2930
const tokenData = tokenList[token.address?.toLowerCase()];
3031
const testNetworkBackgroundColor = useSelector(getTestNetworkBackgroundColor);
31-
32+
const currentNetwork = useSelector(getCurrentNetwork);
3233
return (
3334
<Box
3435
display={Display.Flex}
@@ -40,6 +41,7 @@ const DetectedTokenDetails = ({
4041
<AvatarNetwork
4142
size={AvatarNetworkSize.Xs}
4243
src={CHAIN_ID_TO_NETWORK_IMAGE_URL_MAP[chainId]}
44+
name={currentNetwork?.nickname || ''}
4345
backgroundColor={testNetworkBackgroundColor}
4446
/>
4547
}

ui/components/app/modals/hide-token-confirmation-modal/hide-token-confirmation-modal.js

+4-5
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,14 @@ function mapStateToProps(state) {
2626
function mapDispatchToProps(dispatch) {
2727
return {
2828
hideModal: () => dispatch(actions.hideModal()),
29-
hideToken: (address, networkClientId) => {
30-
dispatch(
29+
hideToken: async (address, networkClientId) => {
30+
await dispatch(
3131
actions.ignoreTokens({
3232
tokensToIgnore: address,
3333
networkClientId,
3434
}),
35-
).then(() => {
36-
dispatch(actions.hideModal());
37-
});
35+
);
36+
dispatch(actions.hideModal());
3837
},
3938
};
4039
}

ui/components/multichain/detected-token-banner/detected-token-banner.js

+8-24
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useContext, useMemo } from 'react';
1+
import React, { useContext } from 'react';
22
import { useSelector } from 'react-redux';
33
import PropTypes from 'prop-types';
44
import classNames from 'classnames';
@@ -7,9 +7,8 @@ import { useI18nContext } from '../../../hooks/useI18nContext';
77
import {
88
getCurrentChainId,
99
getDetectedTokensInCurrentNetwork,
10+
getAllDetectedTokensForSelectedAddress,
1011
getPreferences,
11-
getSelectedInternalAccount,
12-
getAllDetectedTokens,
1312
getNetworkConfigurationsByChainId,
1413
} from '../../../selectors';
1514
import { MetaMetricsContext } from '../../../contexts/metametrics';
@@ -27,8 +26,9 @@ export const DetectedTokensBanner = ({
2726
}) => {
2827
const t = useI18nContext();
2928
const trackEvent = useContext(MetaMetricsContext);
30-
const allNetworks = useSelector(getNetworkConfigurationsByChainId);
3129
const { tokenNetworkFilter } = useSelector(getPreferences);
30+
const allNetworks = useSelector(getNetworkConfigurationsByChainId);
31+
3232
const allOpts = {};
3333
Object.keys(allNetworks || {}).forEach((chainId) => {
3434
allOpts[chainId] = true;
@@ -39,34 +39,18 @@ export const DetectedTokensBanner = ({
3939
Object.keys(allOpts || {}).length;
4040

4141
const detectedTokens = useSelector(getDetectedTokensInCurrentNetwork);
42-
const { address: selectedAddress } = useSelector(getSelectedInternalAccount);
43-
const allDetectedTokens = useSelector(getAllDetectedTokens);
44-
45-
const { detectedTokensMultichain } = useMemo(() => {
46-
const detectedTokensAllChains = Object.entries(
47-
allDetectedTokens || {},
48-
).reduce((acc, [chainId, chainTokens]) => {
49-
const tokensForAddress = chainTokens[selectedAddress];
50-
if (tokensForAddress) {
51-
acc[chainId] = tokensForAddress.map((token) => ({
52-
...token,
53-
chainId,
54-
}));
55-
}
56-
return acc;
57-
}, {});
58-
59-
return { detectedTokensMultichain: detectedTokensAllChains };
60-
}, [selectedAddress, allDetectedTokens]);
6142

43+
const detectedTokensMultichain = useSelector(
44+
getAllDetectedTokensForSelectedAddress,
45+
);
6246
const chainId = useSelector(getCurrentChainId);
6347

6448
const detectedTokensDetails =
6549
process.env.PORTFOLIO_VIEW && !allNetworksFilterShown
6650
? Object.values(detectedTokensMultichain)
6751
.flat()
6852
.map(({ address, symbol }) => `${symbol} - ${address}`)
69-
: detectedTokens?.map(({ address, symbol }) => `${symbol} - ${address}`);
53+
: detectedTokens.map(({ address, symbol }) => `${symbol} - ${address}`);
7054

7155
const totalTokens =
7256
process.env.PORTFOLIO_VIEW && !allNetworksFilterShown

0 commit comments

Comments
 (0)