Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped Create activity and its actor have different origins #1537

Open
silverpill opened this issue Mar 31, 2025 · 1 comment · May be fixed by #1173
Open

Wrapped Create activity and its actor have different origins #1537

silverpill opened this issue Mar 31, 2025 · 1 comment · May be fixed by #1173
Assignees
Labels
activitypub ActivityPub related issues bug Something isn't working

Comments

@silverpill
Copy link

Describe the bug

Activity:

{
  "@context": "https://www.w3.org/ns/activitystreams",
  "actor": "https://gehirneimer.de/m/mbinReleases",
  "cc": [
    "https://gehirneimer.de/m/mbinReleases",
    "https://kbin.earth/u/haverholm/followers"
  ],
  "id": "https://gehirneimer.de/f/object/e2c7ebcb-8a92-4722-8546-582065809d48",
  "object": {
    "actor": "https://kbin.earth/u/haverholm",
    "cc": [
      "https://gehirneimer.de/m/mbinReleases",
      "https://kbin.earth/u/haverholm/followers"
    ],
    "id": "https://gehirneimer.de/f/object/1f1aa307-0138-4ffa-91b1-770a0ca09c5d",
    "object": {
      "attributedTo": "https://kbin.earth/u/haverholm",
      "cc": [
        "https://gehirneimer.de/m/mbinReleases",
        "https://kbin.earth/u/haverholm/followers"
      ],
      "content": "<blockquote>\n<p>Blocked or Deleted Users cannot send you private messages anymore</p>\n</blockquote>\n<p>Thanks devs! Sorry Nicole!</p>\n",
      "contentMap": {
        "en": "<blockquote>\n<p>Blocked or Deleted Users cannot send you private messages anymore</p>\n</blockquote>\n<p>Thanks devs! Sorry Nicole!</p>\n"
      },
      "id": "https://kbin.earth/m/[email protected]/t/1128375/-/comment/5895067",
      "inReplyTo": "https://gehirneimer.de/m/mbinReleases/t/557759",
      "mediaType": "text/html",
      "published": "2025-03-31T16:04:15+00:00",
      "sensitive": false,
      "source": {
        "content": ">Blocked or Deleted Users cannot send you private messages anymore\r\n\r\nThanks devs! Sorry Nicole!",
        "mediaType": "text/markdown"
      },
      "tag": [
        {
          "href": "https://gehirneimer.de/tag/mbinReleases",
          "name": "#mbinReleases",
          "type": "Hashtag"
        },
        {
          "href": "https://gehirneimer.de/u/BentiGorlich",
          "name": "@[email protected]",
          "type": "Mention"
        }
      ],
      "to": [
        "https://www.w3.org/ns/activitystreams#Public",
        "https://gehirneimer.de/u/BentiGorlich"
      ],
      "type": "Note",
      "url": "https://kbin.earth/m/[email protected]/t/1128375/-/comment/5895067"
    },
    "published": "2025-03-31T16:04:15+00:00",
    "to": [
      "https://www.w3.org/ns/activitystreams#Public",
      "https://gehirneimer.de/u/BentiGorlich"
    ],
    "type": "Create"
  },
  "published": "2025-03-31T16:04:17+00:00",
  "to": [
    "https://www.w3.org/ns/activitystreams#Public",
    "https://kbin.earth/u/haverholm"
  ],
  "type": "Announce"
}

Announce.object.actor is https://kbin.earth/u/haverholm
Announce.object.id is https://gehirneimer.de/f/object/1f1aa307-0138-4ffa-91b1-770a0ca09c5d

An actor from kbin.earth created activity on gehirneimer.de, but normally it shouldn't be allowed to do that. The created object doesn't have this problem, its id and attributedTo have same origin.

On which Mbin instance did you find the bug?

https://gehirneimer.de/

Which Mbin version was running on the instance?

1.8.1

Expected behavior

Announce.object.id and Announce.object.actor to be on the same domain.

@silverpill silverpill added the bug Something isn't working label Mar 31, 2025
@BentiGorlich
Copy link
Member

You are absolutely right. I cannot tell you why it was initially implemented this way. I have been working for a fix for this (and a few other things) in #1173
So this issue will be solved by that PR

@BentiGorlich BentiGorlich added the activitypub ActivityPub related issues label Mar 31, 2025
@BentiGorlich BentiGorlich self-assigned this Mar 31, 2025
@BentiGorlich BentiGorlich linked a pull request Mar 31, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activitypub ActivityPub related issues bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants