Skip to content

Commit 3ee27e7

Browse files
committed
🐛 Followup to JyersUI
1 parent 6cf2cf7 commit 3ee27e7

File tree

7 files changed

+23
-20
lines changed

7 files changed

+23
-20
lines changed

Marlin/src/MarlinCore.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@
2323

2424
#include "inc/MarlinConfig.h"
2525

26-
#ifdef DEBUG_GCODE_PARSER
27-
#include "gcode/parser.h"
28-
#endif
29-
3026
#include <math.h>
3127
#include <stdio.h>
3228
#include <stdlib.h>

Marlin/src/gcode/gcode.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@
2121
*/
2222
#pragma once
2323

24-
/**
25-
* gcode.h - Temporary container for all gcode handlers
26-
*/
27-
2824
/**
2925
* -----------------
3026
* G-Codes in Marlin

Marlin/src/lcd/e3v2/creality/rotary_encoder.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,9 @@ ENCODER_DiffState Encoder_ReceiveAnalyze() {
145145
const float encoderStepRate = encoderMovementSteps / float(ms - EncoderRate.lastEncoderTime) * 1000;
146146
if (encoderStepRate >= ENCODER_100X_STEPS_PER_SEC) encoderMultiplier = 100;
147147
else if (encoderStepRate >= ENCODER_10X_STEPS_PER_SEC) encoderMultiplier = 10;
148-
else if (encoderStepRate >= ENCODER_5X_STEPS_PER_SEC) encoderMultiplier = 5;
148+
#if ENCODER_5X_STEPS_PER_SEC
149+
else if (encoderStepRate >= ENCODER_5X_STEPS_PER_SEC) encoderMultiplier = 5;
150+
#endif
149151
}
150152
EncoderRate.lastEncoderTime = ms;
151153
}

Marlin/src/lcd/e3v2/enhanced/rotary_encoder.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,9 @@ ENCODER_DiffState Encoder_ReceiveAnalyze() {
145145
const float encoderStepRate = encoderMovementSteps / float(ms - EncoderRate.lastEncoderTime) * 1000;
146146
if (encoderStepRate >= ENCODER_100X_STEPS_PER_SEC) encoderMultiplier = 100;
147147
else if (encoderStepRate >= ENCODER_10X_STEPS_PER_SEC) encoderMultiplier = 10;
148-
else if (encoderStepRate >= ENCODER_5X_STEPS_PER_SEC) encoderMultiplier = 5;
148+
#if ENCODER_5X_STEPS_PER_SEC
149+
else if (encoderStepRate >= ENCODER_5X_STEPS_PER_SEC) encoderMultiplier = 5;
150+
#endif
149151
}
150152
EncoderRate.lastEncoderTime = ms;
151153
}

Marlin/src/lcd/e3v2/jyersui/dwin.cpp

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
#include "../../marlinui.h"
3434
#include "../../../MarlinCore.h"
3535

36+
#include "../../../gcode/gcode.h"
3637
#include "../../../module/temperature.h"
3738
#include "../../../module/planner.h"
3839
#include "../../../module/settings.h"
@@ -180,6 +181,7 @@ bool probe_deployed = false;
180181
CrealityDWINClass CrealityDWIN;
181182

182183
#if HAS_MESH
184+
183185
struct Mesh_Settings {
184186
bool viewer_asymmetric_range = false;
185187
bool viewer_print_value = false;
@@ -362,7 +364,7 @@ CrealityDWINClass CrealityDWIN;
362364
if (v_min > 3e+10F) v_min = 0.0000001;
363365
if (v_max > 3e+10F) v_max = 0.0000001;
364366
if (range > 3e+10F) range = 0.0000001;
365-
char msg[32];
367+
char msg[46];
366368
if (viewer_asymmetric_range) {
367369
dtostrf(-v_min, 1, 3, str_1);
368370
dtostrf( v_max, 1, 3, str_2);
@@ -378,7 +380,8 @@ CrealityDWINClass CrealityDWIN;
378380

379381
};
380382
Mesh_Settings mesh_conf;
381-
#endif
383+
384+
#endif // HAS_MESH
382385

383386
/* General Display Functions */
384387

@@ -4754,11 +4757,13 @@ void CrealityDWINClass::Start_Print(bool sd) {
47544757
printing = true;
47554758
statusmsg[0] = '\0';
47564759
if (sd) {
4757-
if (recovery.valid()) {
4758-
SdFile *diveDir = nullptr;
4759-
const char * const fname = card.diveToFile(true, diveDir, recovery.info.sd_filename);
4760-
card.selectFileByName(fname);
4761-
}
4760+
#if ENABLED(POWER_LOSS_RECOVERY)
4761+
if (recovery.valid()) {
4762+
SdFile *diveDir = nullptr;
4763+
const char * const fname = card.diveToFile(true, diveDir, recovery.info.sd_filename);
4764+
card.selectFileByName(fname);
4765+
}
4766+
#endif
47624767
strcpy_P(filename, card.longest_filename());
47634768
}
47644769
else
@@ -4798,7 +4803,7 @@ void MarlinUI::update() { CrealityDWIN.Update(); }
47984803

47994804
void CrealityDWINClass::State_Update() {
48004805
if ((print_job_timer.isRunning() || print_job_timer.isPaused()) != printing) {
4801-
if (!printing) Start_Print((card.isFileOpen() || recovery.valid()));
4806+
if (!printing) Start_Print(card.isFileOpen() || TERN0(POWER_LOSS_RECOVERY, recovery.valid()));
48024807
else Stop_Print();
48034808
}
48044809
if (print_job_timer.isPaused() != paused) {

Marlin/src/lcd/e3v2/jyersui/rotary_encoder.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,9 @@ ENCODER_DiffState Encoder_ReceiveAnalyze() {
145145
const float encoderStepRate = encoderMovementSteps / float(ms - EncoderRate.lastEncoderTime) * 1000;
146146
if (encoderStepRate >= ENCODER_100X_STEPS_PER_SEC) encoderMultiplier = 100;
147147
else if (encoderStepRate >= ENCODER_10X_STEPS_PER_SEC) encoderMultiplier = 10;
148-
else if (encoderStepRate >= ENCODER_5X_STEPS_PER_SEC) encoderMultiplier = 5;
148+
#if ENCODER_5X_STEPS_PER_SEC
149+
else if (encoderStepRate >= ENCODER_5X_STEPS_PER_SEC) encoderMultiplier = 5;
150+
#endif
149151
}
150152
EncoderRate.lastEncoderTime = ms;
151153
}

Marlin/src/lcd/marlinui.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ class MarlinUI {
596596
static inline bool use_click() { return false; }
597597
#endif
598598

599-
#if ENABLED(ADVANCED_PAUSE_FEATURE) && ANY(HAS_LCD_MENU, EXTENSIBLE_UI, HAS_DWIN_E3V2)
599+
#if ENABLED(ADVANCED_PAUSE_FEATURE) && ANY(HAS_LCD_MENU, EXTENSIBLE_UI, DWIN_CREALITY_LCD_ENHANCED, DWIN_CREALITY_LCD_JYERSUI)
600600
static void pause_show_message(const PauseMessage message, const PauseMode mode=PAUSE_MODE_SAME, const uint8_t extruder=active_extruder);
601601
#else
602602
static inline void _pause_show_message() {}

0 commit comments

Comments
 (0)