eth/tracers: fix omitempty for memory and storage (ethereum#31289)

s1na · MariusVanDerWijden · commit 751fb9ef76f2 · 2025-03-13T11:14:28.000+01:00
This fixes a regression in the opcode tracer API where we would log
empty memory and storage fields.
diff --git a/eth/tracers/logger/logger.go b/eth/tracers/logger/logger.go
@@ -179,14 +179,14 @@ func (s *StructLog) toLegacyJSON() json.RawMessage {
 	if len(s.ReturnData) > 0 {
 		msg.ReturnData = hexutil.Bytes(s.ReturnData).String()
 	}
-	if s.Memory != nil {
+	if len(s.Memory) > 0 {
 		memory := make([]string, 0, (len(s.Memory)+31)/32)
 		for i := 0; i+32 <= len(s.Memory); i += 32 {
 			memory = append(memory, fmt.Sprintf("%x", s.Memory[i:i+32]))
 		}
 		msg.Memory = &memory
 	}
-	if s.Storage != nil {
+	if len(s.Storage) > 0 {
 		storage := make(map[string]string)
 		for i, storageValue := range s.Storage {
 			storage[fmt.Sprintf("%x", i)] = fmt.Sprintf("%x", storageValue)

Original file line number	Diff line number	Diff line change
`@@ -179,14 +179,14 @@ func (s *StructLog) toLegacyJSON() json.RawMessage {`
`179`	`179`	`if len(s.ReturnData) > 0 {`
`180`	`180`	`msg.ReturnData = hexutil.Bytes(s.ReturnData).String()`
`181`	`181`	`}`
`182`		`- if s.Memory != nil {`
	`182`	`+ if len(s.Memory) > 0 {`
`183`	`183`	`memory := make([]string, 0, (len(s.Memory)+31)/32)`
`184`	`184`	`for i := 0; i+32 <= len(s.Memory); i += 32 {`
`185`	`185`	`memory = append(memory, fmt.Sprintf("%x", s.Memory[i:i+32]))`
`186`	`186`	`}`
`187`	`187`	`msg.Memory = &memory`
`188`	`188`	`}`
`189`		`- if s.Storage != nil {`
	`189`	`+ if len(s.Storage) > 0 {`
`190`	`190`	`storage := make(map[string]string)`
`191`	`191`	`for i, storageValue := range s.Storage {`
`192`	`192`	`storage[fmt.Sprintf("%x", i)] = fmt.Sprintf("%x", storageValue)`