Skip to content

Avoid the need of subclassing PullUpController #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
penaeric opened this issue Oct 15, 2018 · 3 comments
Open

Avoid the need of subclassing PullUpController #30

penaeric opened this issue Oct 15, 2018 · 3 comments

Comments

@penaeric
Copy link

I think it'd be better to use composition over inheritance for obvious reasons. In my case, working with a big project, it's hard to change your view controllers to inherit from a new type.
Since the code is abstracted in a nice way, it should be easily doable by moving all the logic to some type of manager. In fact, I've been playing with the code and I have it (mostly) working... I just ran into a couple of what seem small bugs.
I can open a PR once I clean up the code a bit, but wanted to get your take @MarioIannotta to see what you thought about this possible refactor.

@MarioIannotta
Copy link
Owner

Hi Eric, I totally agree with you.
I'm just a little bit afraid of this "manager thing", I hope singletons are not involved in your refactor :)

@penaeric
Copy link
Author

No singletons at all :)
Hope to have a PR soon

@ebsamson3
Copy link

ebsamson3 commented Oct 9, 2019

To me it makes it most sense to turn it into a container view that you can add a content view controller to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants