Fix Adhese bid adapter user sync (prebid#3453)

Author: mefjush

modules/adheseBidAdapter.js

@@ -52,16 +52,19 @@ export const spec = {
       .map(item => adResponse(item.bid, item.ad));
   },
 
-  getUserSyncs: function(syncOptions, serverResponse, gdprConsent) {
-    const account = serverResponse.account || '';
-    if (syncOptions.iframeEnabled) {
-      let syncurl = USER_SYNC_BASE_URL + '?account=' + account;
-      if (gdprConsent) {
-        syncurl += '&gdpr=' + (gdprConsent.gdprApplies ? 1 : 0);
-        syncurl += '&consentString=' + encodeURIComponent(gdprConsent.consentString || '');
+  getUserSyncs: function(syncOptions, serverResponses, gdprConsent) {
+    if (syncOptions.iframeEnabled && serverResponses.length > 0) {
+      const account = serverResponses[0].account;
+      if (account) {
+        let syncurl = USER_SYNC_BASE_URL + '?account=' + account;
+        if (gdprConsent) {
+          syncurl += '&gdpr=' + (gdprConsent.gdprApplies ? 1 : 0);
+          syncurl += '&consentString=' + encodeURIComponent(gdprConsent.consentString || '');
+        }
+        return [{type: 'iframe', url: syncurl}];
       }
-      return [{ type: 'iframe', url: syncurl }];
     }
+    return [];
   }
 };
 

test/spec/modules/adheseBidAdapter_spec.js

@@ -25,18 +25,24 @@ let bidWithParams = function(data) {
 
 describe('AdheseAdapter', function () {
   describe('getUserSyncs', function () {
-    const serverResponse = {
+    const serverResponses = [{
       account: 'demo'
-    };
+    }];
     const gdprConsent = {
       gdprApplies: true,
       consentString: 'CONSENT_STRING'
     };
     it('should return empty when iframe disallowed', function () {
-      expect(spec.getUserSyncs({ iframeEnabled: false }, serverResponse, gdprConsent)).to.be.empty;
+      expect(spec.getUserSyncs({ iframeEnabled: false }, serverResponses, gdprConsent)).to.be.empty;
+    });
+    it('should return empty when no serverResponses present', function () {
+      expect(spec.getUserSyncs({ iframeEnabled: true }, [], gdprConsent)).to.be.empty;
+    });
+    it('should return empty when no account info present in the response', function () {
+      expect(spec.getUserSyncs({ iframeEnabled: true }, [{}], gdprConsent)).to.be.empty;
     });
     it('should return usersync url when iframe allowed', function () {
-      expect(spec.getUserSyncs({ iframeEnabled: true }, serverResponse, gdprConsent)).to.deep.equal([{ type: 'iframe', url: 'https://user-sync.adhese.com/iframe/user_sync.html?account=demo&gdpr=1&consentString=CONSENT_STRING' }]);
+      expect(spec.getUserSyncs({ iframeEnabled: true }, serverResponses, gdprConsent)).to.deep.equal([{ type: 'iframe', url: 'https://user-sync.adhese.com/iframe/user_sync.html?account=demo&gdpr=1&consentString=CONSENT_STRING' }]);
     });
   });