don't omit all digits when printing ticks #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks good! Will add some tests and then merge. |
|
Bump :) |
|
Bump |
|
Hey, sorry this fell off my radar a bit. I just looked at the diff and realized that at some point the axis code significantly bitrotted so it doesn't respect most tick attributes. So will have to fix that. |
|
Will merge at least as a quick fix for the time being, until I get the whole pipeline figured out and fixed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered this when setting
xticksto0:2.5:20and getting the following tick labels:3 significant digits is still a rather arbitrary choice but seems better than the current behavior.