Makie 0.23 compat (#666)

Author: jkrumbiegel

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## v0.11.0 - 2025-06-16
+
+- **Breaking** Added Makie 0.23 compat. As Makie 0.23 split up `Arrows` in `Arrows2D` and `Arrows3D`, `visual(Arrows2D)` needs to be specified explicitly now in AlgebraOfGraphics. As `Arrows2D` plots polygon shapes now and not a mixture of scatters and lines, the categorical `arrowhead` marker aesthetic had to be removed [#666](https://github.com/MakieOrg/AlgebraOfGraphics.jl/pull/666).
+
 ## v0.10.8 - 2025-06-06
 
 - Added support for the Makie's new `Annotation` recipe [#663](https://github.com/MakieOrg/AlgebraOfGraphics.jl/pull/663).

Project.toml

@@ -1,7 +1,7 @@
 name = "AlgebraOfGraphics"
 uuid = "cbdf2221-f076-402e-a563-3d30da359d67"
 authors = ["Pietro Vertechi", "Julius Krumbiegel"]
-version = "0.10.8"
+version = "0.10.9"
 
 [deps]
 Accessors = "7d9f7c33-5ae7-4f3b-8dc6-eff91059b697"
@@ -50,7 +50,7 @@ GridLayoutBase = "0.6, 0.7, 0.8, 0.9, 0.10, 0.11"
 Isoband = "0.1"
 KernelDensity = "0.6"
 Loess = "0.5.1, 0.6.1"
-Makie = "0.22.10"
+Makie = "0.23"
 NaturalSort = "1"
 PlotUtils = "1"
 PolygonOps = "0.1.1"

docs/src/examples/scales/custom-scales.md

@@ -17,13 +17,11 @@ c=rand(Bool, length(x))
 d=rand(Bool, length(x))
 df = (; x, y, u, v, c, d)
 colors = [colorant"#E24A33", colorant"#348ABD"]
-heads = ['◮', '◭']
 plt = data(df) *
     mapping(:x, :y, :u, :v) *
-    mapping(arrowhead = :c => nonnumeric) *
     mapping(color = :d => nonnumeric) *
-    visual(Arrows, arrowsize=10, lengthscale=0.4, linewidth = 1)
-fg = draw(plt, scales(Marker = (; palette = heads), Color = (; palette = colors)))
+    visual(Arrows2D, lengthscale=0.4)
+fg = draw(plt, scales(Color = (; palette = colors)))
 ````
 
 To associate specific attribute values to specific data values, use pairs.

src/aesthetics.jl

@@ -361,14 +361,13 @@ function aesthetic_mapping(::Type{QQPlot}, ::Normal, ::Normal)
     ])
 end
 
-function aesthetic_mapping(::Type{Arrows}, ::Normal, ::Normal, ::Normal, ::Normal)
+function aesthetic_mapping(::Type{Arrows2D}, ::Normal, ::Normal, ::Normal, ::Normal)
     dictionary([
         1 => AesX,
         2 => AesY,
         3 => AesDeltaX,
         4 => AesDeltaY,
         :color => AesColor,
-        :arrowhead => AesMarker,
     ])
 end
 

src/guides/legend.jl

@@ -461,18 +461,14 @@ function legend_elements(T::Type{<:Union{Band,VSpan,HSpan}}, attributes, scale_a
     )]
 end
 
-function legend_elements(T::Type{Arrows}, attributes, scale_args::MixedArguments)
-    marker = _get(T, scale_args, attributes, :arrowhead)
-    marker = marker === Makie.automatic ? :utriangle : marker # Makie handles this internally due to the 2d/3d combination. This should probably be fixed in Makie
+function legend_elements(T::Type{Arrows2D}, attributes, scale_args::MixedArguments)
     [
         LineElement(
             color = _get(T, scale_args, attributes, :color),
-            linewidth = _get(T, scale_args, attributes, :linewidth),
-            linestyle = _get(T, scale_args, attributes, :linestyle),
             linepoints = [Point2(0.5, 0), Point2(0.5, 0.75)]
         ),
         MarkerElement(;
-            marker,
+            marker = :utriangle, # Makie handles this internally due to the 2d/3d combination. This should probably be fixed in Makie,
             color = _get(T, scale_args, attributes, :color),
             markerpoints = [Point2(0.5, 0.75)],
         ),

test/reference_tests.jl

@@ -679,7 +679,7 @@ reftest("qqplot") do
     data((; x = sin.(1:100), y = sin.((1:100) .+ 0.2))) * mapping(:x, :y) * visual(QQPlot, qqline = :identity) |> draw
 end
 
-reftest("arrows cat color and marker") do
+reftest("arrows cat color") do
     x=repeat(1:10, inner=10)
     y=repeat(1:10, outer=10)
     u=cos.(x)
@@ -688,13 +688,11 @@ reftest("arrows cat color and marker") do
     d=round.(Bool, cos.(1:100) .* 0.5 .+ 0.5)
     df = (; x, y, u, v, c, d)
     colors = [colorant"#E24A33", colorant"#348ABD"]
-    heads = ['◮', '◭']
     plt = data(df) *
         mapping(:x, :y, :u, :v) *
-        mapping(arrowhead = :c => nonnumeric) *
         mapping(color = :d => nonnumeric) *
-        visual(Arrows, arrowsize=14, lengthscale=0.4, linewidth = 1)
-    fg = draw(plt, scales(Marker = (; palette = heads), Color = (; palette = colors)))
+        visual(Arrows2D, lengthscale=0.4)
+    fg = draw(plt, scales(Color = (; palette = colors)))
 end
 
 reftest("continuous missings") do