fix(pinia): 🐛 fix votes update

Author: AnzhiZhang

pages/plugins/[id].vue

@@ -63,11 +63,6 @@ const pluginsStore = usePluginsStore();
 // https://github.com/vuejs/pinia/issues/1080
 await pluginsStore.nuxtServerInit();
 
-// update votes on mounted
-onMounted(() => {
-  pluginsStore.updatePluginVotes();
-});
-
 // check if plugin exists
 if (!pluginsStore.exists(id)) {
   showError({

pages/plugins/index.vue

@@ -135,11 +135,6 @@ const pluginsStore = usePluginsStore();
 // https://github.com/vuejs/pinia/issues/1080
 await pluginsStore.nuxtServerInit();
 
-// update votes on mounted
-onMounted(() => {
-  pluginsStore.updatePluginVotes();
-});
-
 // ----------------------------------------------------------------------------
 // infinite scroll
 // ----------------------------------------------------------------------------

server/api/pluginsVotes.ts

@@ -1,10 +1,6 @@
 import {PluginVotesSummary} from "~/types/plugins";
 import {useBackend} from "~/composables/useBackend";
 
-export default defineCachedEventHandler(
-  async (): Promise<PluginVotesSummary> => await useBackend().fetchVotes(),
-  {
-    name: "pluginsVotes",
-    maxAge: 60,
-  }
+export default defineEventHandler(
+  async (): Promise<PluginVotesSummary> => await useBackend().fetchVotes()
 );

stores/usePluginsStore.ts

@@ -120,18 +120,8 @@ export const usePluginsStore = defineStore("plugins", {
         $fetch("/api/pluginsBrief"),
         $fetch("/api/pluginsVotes"),
       ]);
-    },
-
-    /**
-     * Update plugins votes.
-     */
-    async updatePluginVotes() {
-      if (this.pluginVotesSummary !== undefined) {
-        return;
-      }
-
-      this.pluginVotesSummary = await useBackend().fetchVotes();
 
+      // update votes in brief
       for (const id in this.pluginDataBriefSummary) {
         this.pluginDataBriefSummary[id].votes = this.pluginVotesSummary[id] ?? 0;
       }