fix(compaction group): trivial adjust should also increase divide ver… (risingwavelabs#8484)

soundOfDestiny · web-flow · commit d07f2bbacf64 · 2023-03-11T05:13:12.000Z
diff --git a/src/meta/src/hummock/manager/tests.rs b/src/meta/src/hummock/manager/tests.rs
@@ -1510,8 +1510,8 @@ async fn test_split_compaction_group_on_demand_basic() {
                 .get(&new_group_id)
                 .cloned()
                 .unwrap(),
-            0,
-            "trivial adjust doesn't increase divide version"
+            1,
+            "trivial adjust should aoso increase divide version"
         );
     }
 }
diff --git a/src/storage/hummock_sdk/src/compaction_group/hummock_version_ext.rs b/src/storage/hummock_sdk/src/compaction_group/hummock_version_ext.rs
@@ -225,9 +225,7 @@ impl HummockVersionUpdateExt for HummockVersion {
                             .get_table_ids()
                             .iter()
                             .all(|table_id| member_table_ids.contains(table_id));
-                        if !is_trivial {
-                            sst_info.divide_version += 1;
-                        }
+                        sst_info.divide_version += 1;
                         split_id_vers.push((
                             sst_info.get_id(),
                             sst_info.get_divide_version(),

Original file line number	Diff line number	Diff line change
`@@ -1510,8 +1510,8 @@ async fn test_split_compaction_group_on_demand_basic() {`
`1510`	`1510`	`.get(&new_group_id)`
`1511`	`1511`	`.cloned()`
`1512`	`1512`	`.unwrap(),`
`1513`		`- 0,`
`1514`		`- "trivial adjust doesn't increase divide version"`
	`1513`	`+ 1,`
	`1514`	`+ "trivial adjust should aoso increase divide version"`
`1515`	`1515`	`);`
`1516`	`1516`	`}`
`1517`	`1517`	`}`